Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Add ability to customize command-line arguments passed to Ruby #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zenbro
Copy link

@zenbro zenbro commented Jan 18, 2018

In order to fix problems with utf-8 encoding on specific platforms (#103) and doesn't break something on other platforms.

Copy link
Member

@Arcanemagus Arcanemagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to let the user completely break the provider 😛.

Change this to be a list of additional arguments.

package.json Outdated
"rubyExecutableArgs": {
"title": "Arguments passed to Ruby",
"type": "string",
"default": "-c -w --external-encoding=utf-8 --internal-encoding=utf-8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be additional arguments to pass to Ruby, these ones must be there for the provider to work so there is no reason to let the user remove them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 5ccf337 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants