-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Courtroom slide transitions #959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salanto
previously approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may still want to wait for someone else to review this too cause that looks a bit too large for single approval. |
Fixed, PR is review and merge ready. |
Closing, rebased manually on a different branch, see #966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of #869, now with 70% fewer merge conflicts.
Took the old code verbatim and added pair support,. As far as my testing shows, this kinda just works.
Formatting required for setup:
Full courtroom image (should be named "court.png" but can work with any name)
Design.ini parameters:
where "court:pos" is the main image and the name of its subposition.
pos_center
is the pixel position of the center of the part of the image you want to be a positionand the transition duration settings are formatted as
slide_ms_pos
and a duration in milliseconds.Additionally, there is support for giving characters a special pose during transitions if an "Objection!" shout was used.
This PR also adds a checkbox to the main UI to enable or disable sending the new MS parameter
SLIDE
which dictates whether a message is able to trigger a slide animation.Additionally, a global setting is now in the settings menu to disable slide animations for yourself.