Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Courtroom slide transitions #959

Closed
wants to merge 13 commits into from
Closed

[Feature] Courtroom slide transitions #959

wants to merge 13 commits into from

Conversation

in1tiate
Copy link
Member

@in1tiate in1tiate commented May 15, 2024

Refactor of #869, now with 70% fewer merge conflicts.

Took the old code verbatim and added pair support,. As far as my testing shows, this kinda just works.

Formatting required for setup:

Full courtroom image (should be named "court.png" but can work with any name)
Design.ini parameters:

[court:def]
pos_center=320
slide_ms_pro=550
slide_ms_wit=500

[court:wit]
pos_center=1467
slide_ms_pro=500
slide_ms_def=500

[court:pro]
pos_center=2614
slide_ms_def=550
slide_ms_wit=500

where "court:pos" is the main image and the name of its subposition.
pos_center is the pixel position of the center of the part of the image you want to be a position
and the transition duration settings are formatted as slide_ms_pos and a duration in milliseconds.

Additionally, there is support for giving characters a special pose during transitions if an "Objection!" shout was used.

[Options]
objection_pose = pointing

This PR also adds a checkbox to the main UI to enable or disable sending the new MS parameter SLIDE which dictates whether a message is able to trigger a slide animation.

Additionally, a global setting is now in the settings menu to disable slide animations for yourself.

@in1tiate in1tiate requested a review from Salanto May 15, 2024 16:08
Salanto
Salanto previously approved these changes May 16, 2024
Copy link
Contributor

@Salanto Salanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor

@Salanto
Copy link
Contributor

Salanto commented May 16, 2024

You may still want to wait for someone else to review this too cause that looks a bit too large for single approval.

@in1tiate
Copy link
Member Author

in1tiate commented May 16, 2024

experiencing a bizarre frame effects bug, will check on it tomorrow

Fixed, PR is review and merge ready.

@in1tiate
Copy link
Member Author

image
ah. Stand by

@in1tiate
Copy link
Member Author

Closing, rebased manually on a different branch, see #966

@in1tiate in1tiate closed this May 20, 2024
@in1tiate in1tiate deleted the coolslide branch June 18, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants