Fix invalid file paths causing unexpected behavior #975
+174
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to display null pixmap, do a check in the appropriate part where you need it to display. Don't modify AnimationLoader that already knows how to deal with non-existing or invalid files. |
|
What exactly required the null pixmap to function properly? |
|
Per outside discussion, rewrote this to simply hide the offending layer instead of loading a null pixmap. |
* Added screen slide timer * Added so that the animation becomes interruptible.
TrickyLeifa
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the layer refactor, invalid images would display a null pixmap. This restores that behavior.