Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate for client pull request #355

Merged
merged 2 commits into from
May 15, 2024
Merged

Boilerplate for client pull request #355

merged 2 commits into from
May 15, 2024

Conversation

in1tiate
Copy link
Member

@in1tiate in1tiate commented May 9, 2024

Necessary boilerplate for both AttorneyOnline/AO2-Client#953 and AttorneyOnline/AO2-Client#780.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 12.78%. Comparing base (b522d31) to head (e29c9b4).

Files Patch % Lines
core/src/packet/packet_ms.cpp 0.00% 2 Missing ⚠️
core/src/packet/packet_id.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   12.79%   12.78%   -0.01%     
==========================================
  Files          56       56              
  Lines        4761     4763       +2     
==========================================
  Hits          609      609              
- Misses       4152     4154       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@in1tiate in1tiate merged commit 7e9227f into master May 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants