Use client_button instead of objection_button #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we use objection_button class for the shouts, but the toggleShout function actually changes it to client_button instead. This makes it change style (height) whenever it is pressed. We can fix this by just using client_button. That makes it look more like the rest of the buttons as well. Since we don't use objection_button anymore, remove it from the styles.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use objection_button class for the shouts, but the toggleShout function actually changes it to client_button instead. This makes it change style (height) whenever it is pressed. We can fix this by just using client_button. That makes it look more like the rest of the buttons as well.
Since we don't use objection_button anymore, remove it from the styles.