Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes firefighter helmets #20435

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

FearTheGabby
Copy link
Contributor

@FearTheGabby FearTheGabby commented Feb 1, 2025

Basically, firefighter helmets didn't have heat protection assigned to the head, nor did non-atmos firefighter helmets have a maximum heat protection value assigned. This meant that

  1. Heat would seep through the helmet and burn the mob anyway, making firesuit loadouts essentially functionless
  2. Vaurca Bulwarks had no way of protecting against fires because of the above and the fact that they can't wear voidsuits

This rectifies that.

image

@FearTheGabby
Copy link
Contributor Author

!review

@FearTheGabby FearTheGabby changed the title fixes firefighter helmets; gives bulwarks high pressure protection Fixes firefighter helmets; gives Bulwarks high pressure protection Feb 1, 2025
Comment on lines 383 to 385
hazard_high_pressure = 3000
warning_high_pressure = 2775

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering they have other advantages, I don't see why they would also need to be resistant to high pressure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they're going to be an engineer, they need to be able to survive issues engineers will run into. Bulwarks are also heavy duty units, they have some advantages and some weaknesses, and i don't think an instant death situation they could run into on the job is exactly fair or logical

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second pass, Bulwarks' standard high pressure resistance seems to be enough combined with a firesuit to handle the pressure created by a phoron fire, so I'll retract that part of the PR for now.

@FearTheGabby FearTheGabby changed the title Fixes firefighter helmets; gives Bulwarks high pressure protection Fixes firefighter helmets Feb 1, 2025
@FearTheGabby
Copy link
Contributor Author

!bugfix

@BotBOREALIS BotBOREALIS added the Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. label Feb 1, 2025
@Arrow768 Arrow768 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into Aurorastation:master with commit 36f3ca0 Feb 3, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants