-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes firefighter helmets #20435
Fixes firefighter helmets #20435
Conversation
!review |
hazard_high_pressure = 3000 | ||
warning_high_pressure = 2775 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering they have other advantages, I don't see why they would also need to be resistant to high pressure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're going to be an engineer, they need to be able to survive issues engineers will run into. Bulwarks are also heavy duty units, they have some advantages and some weaknesses, and i don't think an instant death situation they could run into on the job is exactly fair or logical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second pass, Bulwarks' standard high pressure resistance seems to be enough combined with a firesuit to handle the pressure created by a phoron fire, so I'll retract that part of the PR for now.
!bugfix |
Basically, firefighter helmets didn't have heat protection assigned to the head, nor did non-atmos firefighter helmets have a maximum heat protection value assigned. This meant that
This rectifies that.