-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes firefighter helmets #20435
Merged
Merged
Fixes firefighter helmets #20435
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
################################ | ||
# Example Changelog File | ||
# | ||
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. | ||
# | ||
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) | ||
# When it is, any changes listed below will disappear. | ||
# | ||
# Valid Prefixes: | ||
# bugfix | ||
# - (fixes bugs) | ||
# wip | ||
# - (work in progress) | ||
# qol | ||
# - (quality of life) | ||
# soundadd | ||
# - (adds a sound) | ||
# sounddel | ||
# - (removes a sound) | ||
# rscadd | ||
# - (adds a feature) | ||
# rscdel | ||
# - (removes a feature) | ||
# imageadd | ||
# - (adds an image or sprite) | ||
# imagedel | ||
# - (removes an image or sprite) | ||
# spellcheck | ||
# - (fixes spelling or grammar) | ||
# experiment | ||
# - (experimental change) | ||
# balance | ||
# - (balance changes) | ||
# code_imp | ||
# - (misc internal code change) | ||
# refactor | ||
# - (refactors code) | ||
# config | ||
# - (makes a change to the config files) | ||
# admin | ||
# - (makes changes to administrator tools) | ||
# server | ||
# - (miscellaneous changes to server) | ||
################################# | ||
|
||
# Your name. | ||
author: SimpleMaroon | ||
|
||
# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. | ||
delete-after: True | ||
|
||
# Any changes you've made. See valid prefix list above. | ||
# INDENT WITH TWO SPACES. NOT TABS. SPACES. | ||
# SCREW THIS UP AND IT WON'T WORK. | ||
# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. | ||
# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. | ||
changes: | ||
- bugfix: "Firefighter helmets now have proper defense against high heat, meaning that wearing a whole firesuit works again." | ||
- qol: "Vaurca Bulwarks now have higher pressure protection, since they can work in Engineering but can't wear voidsuits and have to rely on firesuits." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering they have other advantages, I don't see why they would also need to be resistant to high pressure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're going to be an engineer, they need to be able to survive issues engineers will run into. Bulwarks are also heavy duty units, they have some advantages and some weaknesses, and i don't think an instant death situation they could run into on the job is exactly fair or logical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second pass, Bulwarks' standard high pressure resistance seems to be enough combined with a firesuit to handle the pressure created by a phoron fire, so I'll retract that part of the PR for now.