Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYDRA-691 : Move mayaUsd code for managing stages inside mayaHydra #38

Merged
merged 26 commits into from
Feb 2, 2024
Merged

HYDRA-691 : Move mayaUsd code for managing stages inside mayaHydra #38

merged 26 commits into from
Feb 2, 2024

Conversation

lanierd-adsk
Copy link
Collaborator

No description provided.

@lanierd-adsk lanierd-adsk self-assigned this Jan 12, 2024
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk January 12, 2024 15:31
@lanierd-adsk
Copy link
Collaborator Author

FYI : @roopavr-adsk @lilike-adsk @debloip-adsk

@lanierd-adsk lanierd-adsk changed the title HYDRA-691 : Move mayaUsd code for manging stages inside mayHydra HYDRA-691 : Move mayaUsd code for managing stages inside mayHydra Jan 12, 2024
@lanierd-adsk lanierd-adsk marked this pull request as draft January 12, 2024 15:35
@lanierd-adsk
Copy link
Collaborator Author

This won't be merged before our release is done.

@lanierd-adsk
Copy link
Collaborator Author

FYI : @lilike-adsk , @roopavr-adsk , @debloip-adsk

seando-adsk
seando-adsk requested changes Jan 15, 2024
View reviewed changes
build.py Outdated Show resolved Hide resolved
doc/build.md Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
ppt-adsk
ppt-adsk reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for this.

doc/build.md Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/CMakeLists.txt Outdated Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/sceneIndex/mayaHydraMayaUsdProxyShapeSceneIndex.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/sceneIndex/mayaHydraMayaUsdProxyShapeSceneIndex.cpp Outdated Show resolved Hide resolved
lib/flowViewport/API/fvpFilteringSceneIndexClient.h Show resolved Hide resolved
ppt-adsk
ppt-adsk previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, approving. From an architecture standpoint I am concerned about our use of MObject rather than MDagPath, but this is a wider concern, and should not block this pull request.

lib/flowViewport/API/fvpFilteringSceneIndexClient.h Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
test/lib/mayaUsd/render/mayaToHydra/testMayaUsdAPIUsage.py Outdated Show resolved Hide resolved
seando-adsk
seando-adsk reviewed Jan 26, 2024
View reviewed changes
cmake/test.cmake Show resolved Hide resolved
cmake/test.cmake Outdated Show resolved Hide resolved
cmake/modules/FindMayaUsd.cmake Outdated Show resolved Hide resolved
seando-adsk
seando-adsk requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change left and one question to answer.

seando-adsk
seando-adsk reviewed Jan 29, 2024
View reviewed changes
cmake/test.cmake Outdated Show resolved Hide resolved
seando-adsk
seando-adsk requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change needed in the test.cmake

@lanierd-adsk lanierd-adsk marked this pull request as ready for review February 1, 2024 15:56
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk February 1, 2024 15:56
seando-adsk
seando-adsk previously approved these changes Feb 1, 2024
View reviewed changes
ppt-adsk
ppt-adsk previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments which you can choose to do or not.

lib/mayaHydra/mayaPlugin/renderOverride.cpp Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
@lanierd-adsk lanierd-adsk dismissed stale reviews from ppt-adsk and seando-adsk via e784335 February 2, 2024 10:06
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk February 2, 2024 10:11
@lanierd-adsk lanierd-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 2, 2024
@roopavr-adsk roopavr-adsk added the core Related to core plugin label Feb 2, 2024
@roopavr-adsk roopavr-adsk merged commit 49ea7c8 into dev Feb 2, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the lanierd/HYDRA-691 branch February 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

@seando-adsk seando-adsk seando-adsk left review comments

Assignees

@lanierd-adsk lanierd-adsk

Labels
core Related to core plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lanierd-adsk @ppt-adsk @seando-adsk @roopavr-adsk