HYDRA-824 - add unit test for maya lights #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanierd-adsk
requested changes
Feb 1, 2024
test/lib/mayaUsd/render/mayaToHydra/MayaLightsTest/flatLight.png
Outdated
Show resolved
Hide resolved
test/lib/mayaUsd/render/mayaToHydra/MayaLightsTest/noLight_shadowOn.png
Outdated
Show resolved
Hide resolved
test/lib/mayaUsd/render/mayaToHydra/MayaLightsTest/pointLight_shadowOn.png
Outdated
Show resolved
Hide resolved
test/lib/mayaUsd/render/mayaToHydra/MayaLightsTest/spotLight_shadowOn.png
Outdated
Show resolved
Hide resolved
| import mayaUtils | ||
| import unittest | ||
|
|
||
| class TesMayatLights(mtohUtils.MtohTestCase): #Subclassing mtohUtils.MtohTestCase to be able to call self.assertSnapshotClose |
There was a problem hiding this comment.
The "t" from test has been moved after Maya in the class name. :-) Can you please fix it ? Thanks.
| "testMayaLights", | ||
| "testMayaLights.ma") | ||
| cmds.refresh() | ||
| #Do a view fit --Test removed as on Linux the fit doesn't produce the same result as on Windows and OSX. |
There was a problem hiding this comment.
Can you please remove that commented code which I did in a previous PR, it's not required to keep it. Thanks.
lanierd-adsk
approved these changes
Feb 2, 2024
lilike-adsk
added
test
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the testDirectionalLights test to cover more cases for MAYA lights:
1.different lighting modes
2.shadow on/off