-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch to traefik v3 #90
Conversation
Should route to a different port if specified: Failing tests (return 404 instead of 200): curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.really.lndo.site/everything/for-real | grep 200
curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.things.lndo.site/everything/for-real | grep 200 Should handle sites in subdirectories: Failing tests (404 instead of 200): curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.really.lndo.site/everything/for-real | grep 200 |
proxy:
web3:
- "lets.combine.*.lndo.site:8080/everything/for-real"
- "*.more.web3.lndo.site:8080"
- web3.lndo.site:8080
- web4.lndo.site:8080
- hostname: web5.lndo.site
port: 8080 |
|
Traefik 3 does not seem to support named regexps. https://doc.traefik.io/traefik/v2.11/routing/routers/#rule -HostRegexp(`lets.combine.{wildcard:[a-z0-9-]+}.lndo.site`)
+HostRegexp(`lets.combine.[a-z0-9-]+.lndo.site`) |
diff --git a/plugins/lando-proxy/lib/utils.js b/plugins/lando-proxy/lib/utils.js
index 102f115e..dca72e25 100644
--- a/plugins/lando-proxy/lib/utils.js
+++ b/plugins/lando-proxy/lib/utils.js
@@ -54,7 +54,7 @@ exports.getProxyRunner = (project, files) => ({
*/
exports.getRule = rule => {
// Start with the rule we can assume
- const hostRegex = rule.host.replace(new RegExp('\\*', 'g'), '{wildcard:[a-z0-9-]+}');
+ const hostRegex = rule.host.replace(new RegExp('\\*', 'g'), '[a-z0-9-]+');
const rules = [`HostRegexp(\`${hostRegex}\`)`];
// Add in the path prefix if we can
if (rule.pathname.length > 1) rules.push(`PathPrefix(\`${rule.pathname}\`)`); |
809e8f9 will break tests because the image is not yet in the |
No description provided.