Change Team sync to prefer slack profile's real name opposed to display name #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling team sync updated matrix users' name since it defaults to Slack's display name. In prod, we had real name as the display name which enabled mentioning users work both by their username and name. In order to bring this back, change in this PR changes how users are synced.
This change would ensure anytime a user is synced (at boot or with user_change event), slack's profile real name for the user is set as the name on its corresponding matrix account, if it doesn't match already.
@psrpinto I was able to test this locally and it worked, but please take a closer look. Here's it in action: