Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamsync fix to dynamically create rooms #28

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Teamsync fix to dynamically create rooms #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89f47a7
Revert "let room name be default alias if alias prefix isn't defined"
ashfame Nov 27, 2023
5fe5341
add explanation for revert
ashfame Nov 27, 2023
b42138a
change comment as more was discovered
ashfame Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/TeamSyncer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,11 @@ export class TeamSyncer {
plUsers[admin] = 100;
}

// Important note: default alias needs to be undefined if alias prefix isn't used
// otherwise Synapse refuses to create the room even when room alias is specified, as if it wasn't specified
// Seems like a bug but looking at Synapse's code, I couldn't find what's wrong
const aliasPrefix = this.getAliasPrefix(teamId);
const alias = aliasPrefix ? `${aliasPrefix}${channel.name.toLowerCase()}` : channel.name.toLowerCase();
const alias = aliasPrefix ? `${aliasPrefix}${channel.name.toLowerCase()}` : undefined;
let topic: undefined|string;
if (channel.purpose) {
topic = channel.purpose.value;
Expand Down
Loading