Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lint-staged in husky #7

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Use lint-staged in husky #7

merged 3 commits into from
Feb 19, 2025

Conversation

juanmaguitar
Copy link
Contributor

@juanmaguitar juanmaguitar commented Feb 17, 2025

As I was using this repo to set-up wpvip-learn-enterprise-block-editor repo, I realized the current configuration runs the linter on ALL the local files (including those that are not meant to be committed).

A better default configuration IMO would be to just run the linters on the staged files to be committed (using lint staged)

@ryanwelcher
Copy link
Contributor

This is a great addition @juanmaguitar, thank you!

Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc @claudiulodro

@juanmaguitar juanmaguitar merged commit f60999c into Automattic:trunk Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants