feat(ia): audience subscriptions boilerplate #3565
Conversation
…to feat/ia-audience-subscriptions
…to feat/ia-audience-subscriptions
…feat/ia-audience-subscriptions
…feat/ia-audience-subscriptions
…feat/ia-audience-subscriptions
…feat/ia-audience-subscriptions
jaredrethman
changed the base branch from
epic/ia
to
feat/epic-ia-trunk-rasacc
jaredrethman
added
the
[Status] Needs Review
|
Noting Audience / Subscriptions wizard slug change from |
| 'title' => esc_html__( 'Configuration', 'newspack-plugin' ), | ||
| 'header' => esc_html__( 'Manage Subscriptions settings in Woo Memberships', 'newspack-plugin' ), | ||
| 'description' => esc_html__( 'You can manage the details of your subscription offerings in the Woo Memberships plugin.', 'newspack-plugin' ), | ||
| 'href' => admin_url( 'admin.php?page=wc-settings&tab=memberships' ), |
There was a problem hiding this comment.
Is it confirmed that this is the link we want to redirect to? I don't think we change the defaults here. A better destination would be wp-admin/edit.php?post_type=wc_membership_plan
There was a problem hiding this comment.
Refactored in fefbfba
| [ | ||
| 'path' => '/revenue', | ||
| 'title' => esc_html__( 'Revenue', 'newspack-plugin' ), | ||
| 'header' => esc_html__( 'View Subscription Revenue in WooCommerce', 'newspack-plugin' ), | ||
| 'description' => esc_html__( 'You can view revenue data from Donations and Subscriptions in the WooCommerce Plugin.', 'newspack-plugin' ), | ||
| 'href' => admin_url( 'admin.php?page=wc-reports' ), | ||
| 'btn_text' => esc_html__( 'View Subscription Revenue', 'newspack-plugin' ), | ||
| ], |
There was a problem hiding this comment.
During the presentation, it was pointed out that we shouldn't render this tab while we don't have the link for our custom revenue report.
We can preserve the code but comment it out with a docblock stating the reason.
There was a problem hiding this comment.
Refactored in 60a1787. PHPCS required the space between the block comments, looks little weird.
All Submissions:
Changes proposed in this Pull Request:
Add New IA for Audience > Subscription wizard.
How to test the changes in this Pull Request:
git checkout origin/feat/ia-audience-subscriptions && npm run buildOther information: