feat(dev-env): write integrations config when creating an environment #2199
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjinks
force-pushed
the
write-integrations-config
branch
from
1adb7d1 to
889409c
Compare
|
sjinks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the environment creation workflow to create integration configuration and mount it into WordPress.
Note that WordPress will not load the configuration yet: this requires changes to the
dev-toolsand/orwordpressDocker images, as well as mu-plugins.Related: Automattic/vip-go-mu-plugins#6101
Pull request checklist
New release checklist
Steps to Test
vip @app.env dev-env create < /dev/null~/.local/share/vip/dev-environment/<NAME>/integrations-config/integrations.jsonexistsvip dev-env startvip dev-env shell -- cat /wp/config/integrations-config/integrations.json