Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-env): automatically enable Elasticsearch when Enterprise Search integration is enabled #2206

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jan 27, 2025

Description

This PR updates the code to enable Elasticsearch when a user creates an environment with Enterprise Search integration enabled.

Pull request checklist

New release checklist

Steps to Test

  1. vip @app.env dev-env create --elasticsearch; @app.env must have ES integration enabled.
  2. Observe that Enable Elasticsearch is Y by default (or elasticsearch is among the services when using unattended creation).

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@sjinks sjinks marked this pull request as ready for review January 27, 2025 18:04
@sjinks sjinks self-assigned this Jan 27, 2025
@sjinks sjinks requested a review from Copilot January 27, 2025 18:04
@sjinks sjinks force-pushed the enable/es-integration branch from 3ae1655 to 4e10eec Compare January 27, 2025 18:37
@sjinks sjinks changed the title feat(dev-env): automatically enable ES integration when creating ES-enabled env feat(dev-env): automatically enable Elasticsearch when Enterprise Search integration is enabled Jan 27, 2025
@sjinks sjinks added the [Status] Needs Docs The feature or update requires an update to our public VIP Documentation label Jan 27, 2025
@sjinks sjinks requested a review from rinatkhaziev January 27, 2025 19:19
@rinatkhaziev
Copy link
Contributor

Tested both scenarios, works great.

@sjinks sjinks force-pushed the enable/es-integration branch from 4e10eec to 9f29b2d Compare January 29, 2025 21:02
@sjinks sjinks merged commit 2bf64a4 into trunk Jan 29, 2025
17 checks passed
@sjinks sjinks deleted the enable/es-integration branch January 29, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Docs The feature or update requires an update to our public VIP Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants