Merge pull request #308 from Automattic/versioned-playwright

feat(playwright): allow for specifying Playwright version
Automattic · Aug 8, 2024 · 9c76e92 · 9c76e92
2 parents f232e1a + 1615d91
commit 9c76e92
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/features/src/playwright/NOTES.md b/features/src/playwright/NOTES.md
@@ -0,0 +1,3 @@
+This feature is available only for Debian-based containers.
+
+Alpine-based containers are **not** supported because the browsers used by Playwright are built against `libs`, not `musl`.
diff --git a/features/src/playwright/devcontainer-feature.json b/features/src/playwright/devcontainer-feature.json
@@ -2,12 +2,18 @@
     "id": "playwright",
     "name": "Playwright",
     "description": "Sets up Playwright into the Dev Environment",
-    "version": "1.0.0",
+    "documentationURL": "https://github.com/Automattic/vip-codespaces/tree/trunk/features/src/playwright",
+    "version": "1.1.0",
     "options": {
         "enabled": {
             "type": "boolean",
             "default": true,
             "description": "Enable Playwright"
+        },
+        "version": {
+            "type": "string",
+            "default": "latest",
+            "description": "Playwright version to install"
         }
     }
 }
diff --git a/features/src/playwright/install.sh b/features/src/playwright/install.sh
@@ -11,6 +11,7 @@ fi
 
 : "${_REMOTE_USER:?"_REMOTE_USER is required"}"
 : "${ENABLED:=}"
+PLAYWRIGHT_VERSION="${VERSION:=latest}"
 
 if [ "${ENABLED}" = "true" ]; then
     echo '(*) Installing Playwright...'
@@ -47,7 +48,7 @@ if [ "${ENABLED}" = "true" ]; then
                 apt-get install -y nodejs
             fi
 
-            npm i -g playwright-core
+            npm i -g "playwright-core@${PLAYWRIGHT_VERSION}"
             playwright-core install-deps
             su -s /bin/sh -c 'playwright-core install' "${_REMOTE_USER}"
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		This feature is available only for Debian-based containers.

		Alpine-based containers are not supported because the browsers used by Playwright are built against `libs`, not `musl`.