Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Table row selection (#503) #1031

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

FredLL-Avaiga
Copy link
Member

col is None if the user clicked outside the column text

def on_table_action(state: State, var_name: str, payload: dict):
    print(f"on_table_action(var_name={var_name}, payload={payload})")

on_table_action(var_name=perf_df, payload={'action': 'on_table_action', 'index': 0, 'col': 'Scenario', 'args': []})
on_table_action(var_name=perf_df, payload={'action': 'on_table_action', 'index': 0, 'col': None, 'args': []})

@FredLL-Avaiga FredLL-Avaiga added 📈 Improvement Improvement of a feature. GUI: Front-End Related to the front-end side of Taipy GUI. 🟧 Priority: High Stalls work on the project or its dependents 📝Release Notes Impacts the Release Notes labels Nov 30, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 30, 2023
Copy link

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.36178681999115%

St.
Category Percentage Covered / Total
🟢 Statements
80.63% (-0.21% 🔻)
2294/2845
🟡 Branches
62.36% (-0.26% 🔻)
1410/2261
🟡 Functions
74.81% (-0.28% 🔻)
401/536
🟢 Lines
81.02% (-0.23% 🔻)
2130/2629
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / PaginatedTable.tsx
77.17% (-1.6% 🔻)
70.32% (-1.9% 🔻)
72.97% (-2.03% 🔻)
77.84% (-1.69% 🔻)
🟡
... / AutoLoadingTable.tsx
73.45% (-1.55% 🔻)
52.32% (-1.97% 🔻)
62.79% (-1.5% 🔻)
74.55% (-1.7% 🔻)

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 660da7f

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5301 4525 85% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 660da7f by action🐍

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredLL-Avaiga FredLL-Avaiga merged commit c8dcdae into develop Nov 30, 2023
48 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#503-table-row-selection branch November 30, 2023 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GUI: Front-End Related to the front-end side of Taipy GUI. 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents 📝Release Notes Impacts the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants