Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/doc#986 - Document best practice on main script #1582

Merged

Conversation

trgiangdo
Copy link
Member

Resolves Avaiga/taipy-doc#986

Please review the example in the README.md since it can be important.

@trgiangdo trgiangdo added 📈 Improvement Improvement of a feature. 📄 Documentation Internal or public documentation labels Jul 25, 2024
@trgiangdo trgiangdo self-assigned this Jul 25, 2024
@trgiangdo trgiangdo changed the title feat: update example with if __name__==__main__: in the main script Feature/doc#986 - Document best practice on main script Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19166 16263 85% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/data/data_node.py 99% 🟢
taipy/core/notification/core_event_consumer.py 96% 🟢
taipy/core/scenario/scenario.py 96% 🟢
taipy/core/sequence/sequence.py 99% 🟢
taipy/core/submission/submission.py 95% 🟢
taipy/core/task/task.py 97% 🟢
taipy/gui/init.py 100% 🟢
taipy/gui/builder/page.py 70% 🟢
taipy/rest/api/resources/cycle.py 100% 🟢
taipy/rest/api/resources/datanode.py 96% 🟢
taipy/rest/api/resources/scenario.py 100% 🟢
TOTAL 95% 🟢

updated for commit: f04f6c4 by action🐍

jrobinAV
jrobinAV previously approved these changes Jul 25, 2024
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I just need @fabien to approve it before merging anything.

@trgiangdo trgiangdo requested a review from FlorianJacta July 29, 2024 08:56
Copy link
Contributor

This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Aug 12, 2024
@trgiangdo trgiangdo force-pushed the feature/doc#986-document-best-practice-on-main-script branch from 2f39db6 to f04f6c4 Compare August 14, 2024 03:08
@trgiangdo trgiangdo requested a review from jrobinAV August 14, 2024 03:09
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Aug 14, 2024
@trgiangdo trgiangdo merged commit 09aa046 into develop Aug 22, 2024
158 checks passed
@trgiangdo trgiangdo deleted the feature/doc#986-document-best-practice-on-main-script branch August 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 📈 Improvement Improvement of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect main script from being executed outside the main process
2 participants