fix(workflow-upgrade): fix error getting peerDeps and buffer overflow #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
jordan-a-young
requested review from
chrishavekost,
gregmartDOTin and
LauRoxx
and removed request for
gregmartDOTin and
LauRoxx
packages/workflow-upgrade/index.js
Outdated
| Logger.info('Deleting Package-Lock'); | ||
| fs.unlinkSync(pkgLock); | ||
| // Get latest verison of packages | ||
| let latestWorkflowVersion = await getLatestNpmVersion('@availity/workflow', '10.0.0'); |
There was a problem hiding this comment.
I think we should default to 10.0.6 so bug fixes are included
gregmartDOTin
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr started with trying to fix a bug where an error was thrown because the call to get peerDeps was failing because the lockfile was already deleted. I fixed this issue and also added some enhancements
@availity/workflowandeslint-config-availityis calculated. We now use npm to get latest version