Fix linting issues

AvianNetwork · Nov 28, 2021 · e143215 · e143215
1 parent ae4cb2f
commit e143215
Show file tree

Hide file tree

Showing 64 changed files with 87 additions and 94 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,11 +1,11 @@
 # Blockbook Contributor Guide
 
-Blockbook is back-end service for Trezor wallet. Although it is open source, the design and development of the core packages
-is done by Trezor developers in order to keep Blockbook compatible with Trezor.
+Blockbook is a back-end service for the Trezor wallet. Although it is open source, the design and development of the core packages
+is done by the Trezor developers to keep Blockbook compatible with Trezor.
 
-Bug fixes and support for new coins are welcome. **Please take note that non-fixing pull requests that change base
-packages or another coin code will not be accepted.** If you have a need to change some of the existing code, please file
-an issue and discuss your request with Blockbook maintainers.
+Bug fixes and support for new coins are welcome. **Please take note that pull requests that are not fixes and that change base
+packages or another coin code will not be accepted.** If you need a change in the existing core code, please file
+an issue and discuss your request with the Blockbook maintainers.
 
 ## Development environment
 
@@ -16,8 +16,8 @@ Instructions to set up your development environment and build Blockbook are desc
 
 ### Reporting bugs
 
-A great way to contribute to the project is to send a detailed report when you encounter an issue. We always appreciate
-a well-written, thorough bug report, and will thank you for it!
+A great way to contribute to the project is to send a detailed report when you encounter a problem. We always appreciate
+a well-written and thorough bug report, and we'll be grateful for it!
 
 Check that [our issue database](https://github.com/trezor/blockbook/issues) doesn't already include that problem or
 suggestion before submitting an issue. If you find a match, you can use the "subscribe" button to get notified on

diff --git a/README.md b/README.md
@@ -5,10 +5,10 @@
 **Blockbook** is back-end service for Trezor wallet. Main features of **Blockbook** are:
 
 - index of addresses and address balances of the connected block chain
-- fast searches in the indexes
+- fast index search
 - simple blockchain explorer
 - websocket, API and legacy Bitcore Insight compatible socket.io interfaces
-- support of multiple coins (Bitcoin and Ethereum type), with easy extensibility for other coins
+- support of multiple coins (Bitcoin and Ethereum type) with easy extensibility to other coins
 - scripts for easy creation of debian packages for backend and blockbook
 
 ## Build and installation instructions
@@ -51,7 +51,8 @@ Please add your experience to this [issue](https://github.com/trezor/blockbook/i
 
 #### Error `internalState: database is in inconsistent state and cannot be used`
 
-Blockbook was killed during the initial import, most commonly by OOM killer. By default, Blockbook performs the initial import in bulk import mode, which for performance reasons does not store all the data immediately to the database. If Blockbook is killed during this phase, the database is left in an inconsistent state. 
+Blockbook was killed during the initial import, most commonly by OOM killer. 
+By default, Blockbook performs the initial import in bulk import mode, which for performance reasons does not store all data immediately to the database. If Blockbook is killed during this phase, the database is left in an inconsistent state. 
 
 See above how to reduce the memory footprint, delete the database files and run the import again. 
 
@@ -67,9 +68,9 @@ Your coin's block/transaction data may not be compatible with `BitcoinParser` `P
 
 #### Cannot build Blockbook using `go build` command
 
-When building Blockbook, I get error `not enough arguments in call to _Cfunc_rocksdb_approximate_sizes`.
+When building Blockbook I get error `not enough arguments in call to _Cfunc_rocksdb_approximate_sizes`.
 
-RocksDB version 6.16.0 changed the API in backward incompatible way. It is necessary to build Blockbook with the tag `rocksdb_6_16`, which fixes the compatibility issue. The correct way to build Blockbook is:
+RocksDB version 6.16.0 changed the API in a backwards incompatible way. It is necessary to build Blockbook with the `rocksdb_6_16` tag to fix the compatibility problem. The correct way to build Blockbook is:
 
 ```
 go build -tags rocksdb_6_16

diff --git a/api/types_test.go b/api/types_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package api
 

diff --git a/bchain/baseparser_test.go b/bchain/baseparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package bchain
 

diff --git a/bchain/coins/bch/bcashparser_test.go b/bchain/coins/bch/bcashparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package bch
 

diff --git a/bchain/coins/bellcoin/bellcoinparser_test.go b/bchain/coins/bellcoin/bellcoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package bellcoin
 

diff --git a/bchain/coins/bitcore/bitcoreparser_test.go b/bchain/coins/bitcore/bitcoreparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package bitcore
 

diff --git a/bchain/coins/bitzeny/bitzenyparser_test.go b/bchain/coins/bitzeny/bitzenyparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package bitzeny
 

diff --git a/bchain/coins/btc/bitcoinparser_test.go b/bchain/coins/btc/bitcoinparser_test.go
@@ -1,5 +1,4 @@
 //go:build unittest
-// +build unittest
 
 package btc
 

diff --git a/bchain/coins/btg/bgoldparser_test.go b/bchain/coins/btg/bgoldparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package btg
 

diff --git a/bchain/coins/dash/dashparser_test.go b/bchain/coins/dash/dashparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package dash
 

diff --git a/bchain/coins/dcr/decredparser_test.go b/bchain/coins/dcr/decredparser_test.go
@@ -1,5 +1,4 @@
 //go:build unittest
-// +build unittest
 
 package dcr
 

diff --git a/bchain/coins/dcr/decredrpc.go b/bchain/coins/dcr/decredrpc.go
@@ -54,7 +54,7 @@ func NewDecredRPC(config json.RawMessage, pushHandler func(bchain.NotificationTy
 		Dial:                (&net.Dialer{KeepAlive: 600 * time.Second}).Dial,
 		MaxIdleConns:        100,
 		MaxIdleConnsPerHost: 100, // necessary to not to deplete ports
-		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+		TLSClientConfig:     &tls.Config{InsecureSkipVerify: true},
 	}
 
 	d := &DecredRPC{

diff --git a/bchain/coins/deeponion/deeponionparser_test.go b/bchain/coins/deeponion/deeponionparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package deeponion
 

diff --git a/bchain/coins/digibyte/digibyteparser.go b/bchain/coins/digibyte/digibyteparser.go
@@ -6,14 +6,14 @@ import (
 	"github.com/trezor/blockbook/bchain/coins/btc"
 )
 
+// network constants
 const (
-	// MainnetMagic is mainnet network constant
 	MainnetMagic wire.BitcoinNet = 0xdab6c3fa
 	TestnetMagic wire.BitcoinNet = 0xddbdc8fd
 )
 
+// parser parameters
 var (
-	// MainNetParams are parser parameters for mainnet
 	MainNetParams chaincfg.Params
 	TestNetParams chaincfg.Params
 )

diff --git a/bchain/coins/digibyte/digibyteparser_test.go b/bchain/coins/digibyte/digibyteparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package digibyte
 

diff --git a/bchain/coins/divi/diviparser_test.go b/bchain/coins/divi/diviparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package divi
 

diff --git a/bchain/coins/dogecoin/dogecoinparser_test.go b/bchain/coins/dogecoin/dogecoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package dogecoin
 

diff --git a/bchain/coins/eth/erc20_test.go b/bchain/coins/eth/erc20_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package eth
 

diff --git a/bchain/coins/eth/ethparser_test.go b/bchain/coins/eth/ethparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package eth
 

diff --git a/bchain/coins/firo/firoparser.go b/bchain/coins/firo/firoparser.go
@@ -26,11 +26,11 @@ const (
 	TestnetMagic wire.BitcoinNet = 0xcffcbeea
 	RegtestMagic wire.BitcoinNet = 0xfabfb5da
 
-	GenesisBlockTime       = 1414776286
-	SwitchToMTPBlockHeader = 1544443200
+	GenesisBlockTime                  = 1414776286
+	SwitchToMTPBlockHeader            = 1544443200
 	SwitchToProgPowBlockHeaderTestnet = 1630069200
 	SwitchToProgPowBlockHeaderMainnet = 1635228000
-	MTPL                   = 64
+	MTPL                              = 64
 
 	SpendTxID = "0000000000000000000000000000000000000000000000000000000000000000"
 
@@ -159,7 +159,7 @@ func (p *FiroParser) ParseBlock(b []byte) (*bchain.Block, error) {
 	}
 
 	// then ProgPow or MTP header
-	if(isProgPow(header, p.Params.Net == TestnetMagic)){
+	if isProgPow(header, p.Params.Net == TestnetMagic) {
 		progPowHeader := ProgPowBlockHeader{}
 
 		// header

diff --git a/bchain/coins/firo/firoparser_test.go b/bchain/coins/firo/firoparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package firo
 

diff --git a/bchain/coins/flo/floparser_test.go b/bchain/coins/flo/floparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package flo
 

diff --git a/bchain/coins/fujicoin/fujicoinparser_test.go b/bchain/coins/fujicoin/fujicoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package fujicoin
 

diff --git a/bchain/coins/gamecredits/gamecreditsparser_test.go b/bchain/coins/gamecredits/gamecreditsparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package gamecredits
 

diff --git a/bchain/coins/grs/grsparser.go b/bchain/coins/grs/grsparser.go
@@ -50,7 +50,7 @@ type GroestlcoinParser struct {
 func NewGroestlcoinParser(params *chaincfg.Params, c *btc.Configuration) *GroestlcoinParser {
 	return &GroestlcoinParser{
 		BitcoinParser: btc.NewBitcoinParser(params, c),
-		baseparser:        &bchain.BaseParser{},
+		baseparser:    &bchain.BaseParser{},
 	}
 }
 

diff --git a/bchain/coins/grs/grsparser_test.go b/bchain/coins/grs/grsparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package grs
 

diff --git a/bchain/coins/koto/kotoparser_test.go b/bchain/coins/koto/kotoparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package koto
 

diff --git a/bchain/coins/liquid/liquidparser_test.go b/bchain/coins/liquid/liquidparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package liquid
 

diff --git a/bchain/coins/litecoin/litecoinparser_test.go b/bchain/coins/litecoin/litecoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package litecoin
 

diff --git a/bchain/coins/monacoin/monacoinparser_test.go b/bchain/coins/monacoin/monacoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package monacoin
 

diff --git a/bchain/coins/monetaryunit/monetaryunitparser_test.go b/bchain/coins/monetaryunit/monetaryunitparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package monetaryunit
 

diff --git a/bchain/coins/myriad/myriadparser_test.go b/bchain/coins/myriad/myriadparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package myriad
 

diff --git a/bchain/coins/namecoin/namecoinparser_test.go b/bchain/coins/namecoin/namecoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package namecoin
 

diff --git a/bchain/coins/nuls/nulsparser_test.go b/bchain/coins/nuls/nulsparser_test.go
@@ -1,5 +1,4 @@
 //go:build unittest
-// +build unittest
 
 package nuls
 

diff --git a/bchain/coins/omotenashicoin/omotenashicoinparser_test.go b/bchain/coins/omotenashicoin/omotenashicoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package omotenashicoin
 

diff --git a/bchain/coins/pivx/pivxparser_test.go b/bchain/coins/pivx/pivxparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package pivx
 

diff --git a/bchain/coins/polis/polisparser_test.go b/bchain/coins/polis/polisparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package polis
 

diff --git a/bchain/coins/qtum/qtumparser_test.go b/bchain/coins/qtum/qtumparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package qtum
 

diff --git a/bchain/coins/ravencoin/ravencoinparser_test.go b/bchain/coins/ravencoin/ravencoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package ravencoin
 

diff --git a/bchain/coins/ritocoin/ritocoinparser_test.go b/bchain/coins/ritocoin/ritocoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package ritocoin
 

diff --git a/bchain/coins/snowgem/snowgemparser_test.go b/bchain/coins/snowgem/snowgemparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package snowgem
 

diff --git a/bchain/coins/trezarcoin/trezarcoinparser_test.go b/bchain/coins/trezarcoin/trezarcoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package trezarcoin
 

diff --git a/bchain/coins/unobtanium/unobtaniumparser_test.go b/bchain/coins/unobtanium/unobtaniumparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package unobtanium
 

diff --git a/bchain/coins/vertcoin/vertcoinparser_test.go b/bchain/coins/vertcoin/vertcoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package vertcoin
 

diff --git a/bchain/coins/viacoin/viacoinparser_test.go b/bchain/coins/viacoin/viacoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package viacoin
 

diff --git a/bchain/coins/vipstarcoin/vipstarcoinparser_test.go b/bchain/coins/vipstarcoin/vipstarcoinparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package vipstarcoin
 

diff --git a/bchain/coins/zec/zcashparser_test.go b/bchain/coins/zec/zcashparser_test.go
@@ -1,4 +1,4 @@
-// +build unittest
+//go:build unittest
 
 package zec
 

diff --git a/bchain/coins/zec/zcashrpc.go b/bchain/coins/zec/zcashrpc.go
@@ -15,6 +15,7 @@ type ZCashRPC struct {
 	*btc.BitcoinRPC
 }
 
+// ResGetBlockChainInfo is a response to GetChainInfo request
 type ResGetBlockChainInfo struct {
 	Error  *bchain.RPCError `json:"error"`
 	Result struct {
@@ -72,6 +73,7 @@ func (z *ZCashRPC) Initialize() error {
 	return nil
 }
 
+// GetChainInfo return info about the blockchain
 func (z *ZCashRPC) GetChainInfo() (*bchain.ChainInfo, error) {
 	chainInfo := ResGetBlockChainInfo{}
 	err := z.Call(&btc.CmdGetBlockChainInfo{Method: "getblockchaininfo"}, &chainInfo)