Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX-58678 Adding Megaport EAS HA and logical interfaces #2140

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

sairane10
Copy link
Contributor

@sairane10 sairane10 commented Jan 15, 2025

Adding the following changes for megaport EAS

  • Updating the logical_ifname in interfaces
  • Adding support for creating, updating and delete EAS HA gateway
resource "aviatrix_edge_megaport" "saileeMegaport2" {
    account_name = "megaportacct1"
    gw_name = "saileeMegaportTest2"
    site_id = "testSite1"
    ztp_file_download_path  = "ztp"
    local_as_number = "65489"
    prepend_as_path = ["65489"]

    interfaces {
        gateway_ip = "10.220.14.1"
        ip_address = "10.220.14.10/24"
        logical_ifname = "lan0"
        dns_server_ip = "10.220.14.1"
    }

    interfaces {
        enable_dhcp   = true
        logical_ifname = "mgmt0"
    }

    interfaces {
        gateway_ip    = "192.168.99.1"
        ip_address    = "192.168.99.14/24"
        logical_ifname = "wan0"
        wan_public_ip  = "67.207.104.19"
        dns_server_ip = "192.168.99.1"
    }

    interfaces {
        gateway_ip    = "192.168.88.1"
        ip_address    = "192.168.88.14/24"
        logical_ifname = "wan1"
        wan_public_ip     = "67.71.12.148"
        dns_server_ip = "192.168.88.1"
    }

    interfaces {
        gateway_ip  = "192.168.77.1"
        ip_address  = "192.168.77.14/24"
        logical_ifname = "wan2"
        wan_public_ip   = "67.72.12.149"
        dns_server_ip = "192.168.77.1"
    }

    management_egress_ip_prefix_list = ["162.43.147.137/31"]
}

resource "aviatrix_edge_megaport_ha" "saileeMegaport2Ha" {
    primary_gw_name = "saileeMegaportTest2"
    ztp_file_download_path  = "ztp"

    interfaces {
        gateway_ip = "10.220.14.1"
        ip_address = "10.220.14.11/24"
        logical_ifname = "lan0"
        dns_server_ip = "10.220.14.1"
    }

    interfaces {
        enable_dhcp   = true
        logical_ifname = "mgmt0"
    }

    interfaces {
        gateway_ip    = "192.168.99.1"
        ip_address    = "192.168.99.15/24"
        logical_ifname = "wan0"
        wan_public_ip  = "67.207.104.20"
        dns_server_ip = "192.168.99.1"
    }

    interfaces {
        gateway_ip    = "192.168.88.1"
        ip_address    = "192.168.88.15/24"
        logical_ifname = "wan1"
        wan_public_ip     = "67.71.12.149"
        dns_server_ip = "192.168.88.1"
    }

    interfaces {
        gateway_ip  = "192.168.77.1"
        ip_address  = "192.168.77.15/24"
        logical_ifname = "wan2"
        wan_public_ip   = "67.72.12.150"
        dns_server_ip = "192.168.77.1"
    }

    management_egress_ip_prefix_list = ["162.43.147.139/31"]
}

@sairane10 sairane10 requested a review from a team as a code owner January 15, 2025 19:09
@sairane10 sairane10 requested review from Monkeyanator and tommy-carver and removed request for a team January 15, 2025 19:09
@sairane10 sairane10 marked this pull request as draft January 15, 2025 19:12
@sairane10 sairane10 marked this pull request as ready for review January 16, 2025 18:19
@sairane10
Copy link
Contributor Author

@stewartbutler I have added the changes to the golangci to remove the depguard check. All after running the pre-commit run --all-files locally, some formatting changes were auto made to backport.yaml file

@sairane10 sairane10 force-pushed the sailee/AVX-58678-eas branch from 5795ab6 to 48e1e0b Compare January 21, 2025 20:53
@sairane10 sairane10 force-pushed the sailee/AVX-58678-eas branch from 48e1e0b to af00a6d Compare January 21, 2025 21:00
@vemurisaikartikeya
Copy link

Adding the following changes for megaport EAS

  • Updating the logical_ifname in interfaces
  • Adding support for creating, updating and delete EAS HA gateway
resource "aviatrix_edge_megaport" "saileeMegaport2" {
    account_name = "megaportacct1"
    gw_name = "saileeMegaportTest2"
    site_id = "testSite1"
    ztp_file_download_path  = "ztp"
    local_as_number = "65489"
    prepend_as_path = ["65489"]

    interfaces {
        gateway_ip = "10.220.14.1"
        ip_address = "10.220.14.10/24"
        logical_ifname = "lan0"
        dns_server_ip = "10.220.14.1"
    }

    interfaces {
        enable_dhcp   = true
        logical_ifname = "mgmt0"
    }

    interfaces {
        gateway_ip    = "192.168.99.1"
        ip_address    = "192.168.99.14/24"
        logical_ifname = "wan0"
        wan_public_ip  = "67.207.104.19"
        dns_server_ip = "192.168.99.1"
    }

    interfaces {
        gateway_ip    = "192.168.88.1"
        ip_address    = "192.168.88.14/24"
        logical_ifname = "wan1"
        wan_public_ip     = "67.71.12.148"
        dns_server_ip = "192.168.88.1"
    }

    interfaces {
        gateway_ip  = "192.168.77.1"
        ip_address  = "192.168.77.14/24"
        logical_ifname = "wan2"
        wan_public_ip   = "67.72.12.149"
        dns_server_ip = "192.168.77.1"
    }

    management_egress_ip_prefix_list = ["162.43.147.137/31"]
}

resource "aviatrix_edge_megaport_ha" "saileeMegaport2Ha" {
    primary_gw_name = "saileeMegaportTest2"
    ztp_file_download_path  = "ztp"

    interfaces {
        gateway_ip = "10.220.14.1"
        ip_address = "10.220.14.11/24"
        logical_ifname = "lan0"
        dns_server_ip = "10.220.14.1"
    }

    interfaces {
        enable_dhcp   = true
        logical_ifname = "mgmt0"
    }

    interfaces {
        gateway_ip    = "192.168.99.1"
        ip_address    = "192.168.99.15/24"
        logical_ifname = "wan0"
        wan_public_ip  = "67.207.104.20"
        dns_server_ip = "192.168.99.1"
    }

    interfaces {
        gateway_ip    = "192.168.88.1"
        ip_address    = "192.168.88.15/24"
        logical_ifname = "wan1"
        wan_public_ip     = "67.71.12.149"
        dns_server_ip = "192.168.88.1"
    }

    interfaces {
        gateway_ip  = "192.168.77.1"
        ip_address  = "192.168.77.15/24"
        logical_ifname = "wan2"
        wan_public_ip   = "67.72.12.150"
        dns_server_ip = "192.168.77.1"
    }

    management_egress_ip_prefix_list = ["162.43.147.139/31"]
}

LGTM

Copy link

@tommy-carver tommy-carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait on @stewartbutler review for the non tf stuff

Copy link
Contributor

@stewartbutler stewartbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes LGTM

@sairane10 sairane10 merged commit 996b726 into master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants