Merge pull request #408 from justlevine/chore/strict-types-rules

chore: implement strict types

CHANGELOG.md

@@ -6,6 +6,7 @@
 - chore!: Bump minimum WPGraphQL version to v1.26.0.
 - chore!: Bump minimum WordPress version to v6.0.0.
 - chore!: Bump minimum Gravity Forms version to v2.7.0.
+- chore: Declare `strict_types` in all PHP files.
 - chore: Update Composer dev-dependencies and fix test compatibility with `wp-graphql-test-case` v3.0.x.
 
 ## v0.12.6.1
@@ -159,7 +160,6 @@ Lastly, we've exposed the `connectedChoice` and `connectedInput` fields on `Chec
 - tests: Add tests for `submitGfForm` mutation.
 - docs: replace `formId` with `id` in `submitGfForm` examples. Props: @mosesintech
 
-
 ## v0.11.11 - Bugfix
 
 This _minor_ release fixes a bug where the `ip` field on `GfEntry` was not being properly stored when submitting a form.
@@ -275,7 +275,6 @@ This _minor_ release adds the reCaptcha V2 `type` and `publicKey` to `gfSettings
 - tests: Use `gravityformscli` for installing GF plugins in test envs.
 - chore: Upgrade composer deps
 
-
 ## v0.11.0 - reCAPTCHA Validation, Plugin Updates, and GF 2.6 Support
 
 **:warning: This release contains breaking changes.**

README.md

@@ -105,5 +105,4 @@ Priority support and custom development are available to [our Sponsors](https://
   <a href="https://mysafetyhq.com/" target="_blank" rel="sponsored" title="SafetyHQ (previously Harness Software)"><img src="https://avatars.githubusercontent.com/u/50597878?s=150&v=4" alt="SafetyHQ (previously Harness Software)"></a>
 </div>
 
-
 <a href="https://github.com/sponsors/AxeWP" alt="GitHub Sponsors"><img src="https://img.shields.io/static/v1?label=Sponsor%20Us%20%40%20AxeWP&message=%E2%9D%A4&logo=GitHub&color=%23fe8e86&style=for-the-badge" /></a>

bin/_lib.sh

@@ -145,7 +145,6 @@ install_plugins() {
 	fi
 	wp plugin activate wp-graphql-upload
 
-
 	# Install WPGatsby and Activate
 	if ! $( wp plugin is-installed wp-gatsby ); then
 		wp plugin install wp-gatsby

docker/app.post-setup.sh

@@ -1,6 +1,5 @@
 #!/bin/bash
 
-
 install_gf() {
 	# Install GF plugins and Activate.
 	echo "Installing and Activating Gravity Forms + extensions";
@@ -51,7 +50,6 @@ if ! $( wp plugin is-installed wp-graphql-upload --allow-root ); then
 fi
 wp plugin activate wp-graphql-upload --allow-root
 
-
 # Install WPGatsby and Activate
 if ! $( wp plugin is-installed wp-gatsby --allow-root ); then
 	wp plugin install wp-gatsby --allow-root
@@ -79,6 +77,5 @@ if $(wp maintenance-mode is-active --allow-root); then
 	wp maintenance-mode deactivate --allow-root
 fi
 
-
 chmod 777 -R .
 chown -R $(id -u):$(id -g) .

docker/testing.entrypoint.sh

@@ -23,7 +23,6 @@ run_tests() {
       wp maintenance-mode deactivate --allow-root
     fi
 
-
     # Suites is the comma separated list of suites/tests to run.
     echo "Running Test Suite $suites"
     vendor/bin/codecept run -c codeception.dist.yml "${suites}" ${coverage:-} ${debug:-} --no-exit
@@ -86,7 +85,6 @@ fi
 echo "Running composer install"
 COMPOSER_MEMORY_LIMIT=-1 composer install --no-interaction
 
-
 # Install pcov/clobber if PHP7.1+
 if version_gt $PHP_VERSION 7.0 && [[ -n "$COVERAGE" ]] && [[ -z "$USING_XDEBUG" ]]; then
     echo "Using pcov/clobber for codecoverage"
@@ -145,7 +143,6 @@ if [ -n "$(ls "$TESTS_OUTPUT")" ]; then
     chmod 777 -R "$TESTS_OUTPUT"/*
 fi
 
-
 # Check results and exit accordingly.
 if [ -f "${TESTS_OUTPUT}/failed" ]; then
     echo "Uh oh, something went wrong."

docs/actions-and-filters.md

@@ -53,7 +53,6 @@ do_action( 'graphql_gf_after_register_form_field_' . $field->graphql_single_name
 * **`$field`** _(GF_Field)_ : The Gravity Forms field object.
 * **`$field_settings`** _(array)_ : The Gravity Forms field settings.
 
-
 #### Parameters
 
 * **`$field`** _(GF_Field)_ : The Gravity Forms field object.
@@ -141,7 +140,6 @@ apply_filters( 'graphql_gf_can_view_entries', bool $can_view_entries, int $form_
 * **`$entry_id`** _(string)_ : The entry ID being queried by GraphQL.
 * **`$draft_entry`** _(array)_ : The Gravity Forms entry data array.
 
-
 ### `graphql_gf_entries_connection_query_args`
 
 Filter the Submitted Entry's  $query_args to allow folks to customize queries programmatically.
@@ -365,7 +363,6 @@ apply_filters( 'graphql_gf_form_field_value_fields_' . $field->graphql_single_na
 * **`$fields`** _(array)_ : An array of [WPGraphQL field `$config` arrays](https://www.wpgraphql.com/functions/register_graphql_fields/).
 * **`$field`** _(GF_Field)_ : The Gravity Forms Field object.
 
-
 ### `graphql_gf_form_field_values_input_fields`
 
 Filter to modify the Form Field value GraphQL fields.
@@ -448,7 +445,6 @@ apply_filters( 'graphql_gf_registered_{$type}_classes', array $classes_to_regist
 
 Filters the list of PHP classes that register GraphQL Interfaces based on a particular Gravity Forms field setting.
 
-
 ```php
 apply_filters( 'graphql_gf_registered_{$type}_classes', array $classes_to_register );
 ```

docs/form-field-support.md

@@ -222,7 +222,6 @@ These forms are hidden **by default**:
 
 * `CreditCardField`
 
-
 To enable these plugins, you can define the `WPGRAPHQL_GF_EXPERIMENTAL_FIELDS` constant to true in wp-config.php[https://wordpress.org/support/article/editing-wp-config-php/].
 
 ```php

src/Connection/AbstractConnection.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use WPGraphQL\GF\Interfaces\Hookable;

src/Connection/EntriesConnection.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use GraphQL\Error\UserError;

src/Connection/FormFieldsConnection.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use WPGraphQL\GF\Type\Enum\FormFieldTypeEnum;

src/Connection/FormsConnection.php

@@ -7,6 +7,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use GraphQL\Type\Definition\ResolveInfo;

src/CoreSchemaFilters.php

@@ -6,6 +6,8 @@
  * @since   0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF;
 
 use WPGraphQL\GF\Data\Factory;

src/Data/Connection/EntriesConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GFAPI;

src/Data/Connection/FormFieldsConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GraphQL\Type\Definition\ResolveInfo;

src/Data/Connection/FormsConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GFAPI;

src/Data/EntryObjectMutation.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data;
 
 use Exception;

src/Data/Factory.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data;
 
 use GraphQL\Deferred;

src/Data/FieldValueInput/AbstractFieldValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;

src/Data/FieldValueInput/AddressValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/FieldValueInput/CaptchaValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.11.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;

src/Data/FieldValueInput/CheckboxValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;

src/Data/FieldValueInput/ConsentValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFFormsModel;

src/Data/FieldValueInput/EmailValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/FieldValueInput/FileUploadValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GraphQL\Error\UserError;
@@ -35,6 +37,8 @@ protected function get_field_name(): string {
 	 * @return string|mixed
 	 *
 	 * @throws \GraphQL\Error\UserError
+	 *
+	 * @return string|mixed
 	 */
 	protected function prepare_value() {
 		// Draft entries don't upload files.

src/Data/FieldValueInput/ImageValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;

src/Data/FieldValueInput/ListValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GraphQL\Error\UserError;

src/Data/FieldValueInput/NameValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/FieldValueInput/ProductValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.12.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;

src/Data/FieldValueInput/ValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;
@@ -30,7 +32,7 @@ protected function get_field_name(): string {
 	/**
 	 * {@inheritDoc}
 	 */
-	protected function prepare_value(): string {
+	protected function prepare_value() {
 		// Handle choices with price.
 		if ( ! empty( $this->field->enablePrice ) && false === strpos( $this->args, '|' ) ) {
 			$value_key  = ! empty( $this->field->enablePrice ) || ! empty( $this->field->enableChoiceValue ) ? 'value' : 'text';

src/Data/FieldValueInput/ValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/Loader/DraftEntriesLoader.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFFormsModel;

src/Data/Loader/EntriesLoader.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFAPI;

src/Data/Loader/FormsLoader.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFAPI;

src/Extensions/Extensions.php

@@ -6,6 +6,8 @@
  * @since   0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions;
 
 use WPGraphQL\GF\Extensions\GFChainedSelects\GFChainedSelects;

src/Extensions/GFChainedSelects/Data/FieldValueInput/ChainedSelectValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions\GFChainedSelects\Data\FieldValueInput;
 
 use WPGraphQL\GF\Data\FieldValueInput\CheckboxValuesInput;