Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DataLoader for Form Fields #298

Closed
justlevine opened this issue Sep 14, 2022 · 2 comments
Closed

Implement DataLoader for Form Fields #298

justlevine opened this issue Sep 14, 2022 · 2 comments
Labels
breaking change 💥 type: enhancement ⚡ Improves on an existing feature
Milestone

Comments

@justlevine
Copy link
Member

What problem does this address?

  • Better performance in complex queries by caching the form fields.
  • Enable filtering/pagination with Gatsby (which arbitrarily limits non-top level queries)

What is your proposed solution?

  • We will need to add a unique Global ID.
  • We will likely want to move to a new, namespaced GraphQL type ,while deprecating the existing to give people time to upgrade.
  • We might need to move the Form Field values to their own Type, possibly on the edge. While we got rid of these in the past because they were unweildly to use, the new interfaces introduced in v0.12 could create a better DX this time.

What alternatives have you considered?

No response

Additional Context

No response

@justlevine justlevine added the type: enhancement ⚡ Improves on an existing feature label Sep 14, 2022
@justlevine justlevine added this to the v0.13 milestone Sep 14, 2022
@justlevine justlevine modified the milestones: v0.13, v0.12 Sep 20, 2022
@justlevine
Copy link
Member Author

Punted until more work can be done on the Model/Dataloader API (cc wp-graphql/wp-graphql#2466, wp-graphql/wp-graphql#842, https://github.com/harness-software/harness-wp-plugin/issues/52)

@justlevine justlevine modified the milestones: v0.12, Future Oct 31, 2022
@justlevine justlevine added the status: hold ⚠️ Work on this is on hold due to another issue/ PR label Oct 31, 2022
@justlevine justlevine removed the status: hold ⚠️ Work on this is on hold due to another issue/ PR label May 26, 2024
@justlevine justlevine changed the title Implement DataLoader and Root connection for Form Fields Implement DataLoader for Form Fields Jun 1, 2024
@justlevine
Copy link
Member Author

#416 adds everything but root-level connections.

Don't think still need root-level connections now that the children are valid nodes - even for gatsby - but if there is demonstrated need we can re open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💥 type: enhancement ⚡ Improves on an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant