feat!: implement FormField model, dataloader, and ConnectionResolver #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
FormField
model, which wraps theGF_Field
object.FormFields
dataloader, for storing and caching ourGF_Field
s.FormFieldsConnectionResolver
to useAbstractConnectionResolver
and the new model/dataloader.GfFormField
interface to implement theNode
interface.Why
Part of #298
How
FormField.id
is no longer deprecated, and is now a global Relay ID.Testing Instructions
Additional Info
FormField
resolvers now pass theFormField
model instead of theGF_Field
object. While the model has been set up to pass-through to the underlying object, class checks (e.g.$source instanceof GF_Field
) will _no longer work and should be updated to the following:Checklist: