Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Disk Analyser Config from GCP Connector #236

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

venky999
Copy link
Contributor

@venky999 venky999 commented Dec 31, 2024

This PR removed Disk Analyser Config from GCP Connector. This is due to changes in wiz api where this attribute is not present anymore

closes #237
possible relation to #234

@venky999 venky999 requested a review from a team as a code owner December 31, 2024 10:55
@jschoombee
Copy link
Collaborator

Thanks for the contribution. seems go generate on the gh runners is having issues finding the Terraform binary. Could I request you add a step before to do something like below:

steps:
- uses: hashicorp/setup-terraform@v3

I'm still on vacation and will review in the coming days

@jschoombee
Copy link
Collaborator

It does look like the setting was deprecated at some stage as it is no longer part of the schema. As this was a GCP outposts-related config, do you know what has superseded this (if anything)?

PR looks good to merge, if you would please run the acc tests as per contribution guide and attach the output to the PR, following which this can be released

@venky999
Copy link
Contributor Author

venky999 commented Jan 6, 2025

TF_ACC=1 go test ./internal/acceptance/... -v -run='TestAccResourceWizConnectorGcp_basic'
=== RUN   TestAccResourceWizConnectorGcp_basic
2025/01/06 09:59:55 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 09:59:57 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 09:59:58 [DEBUG] POST https://api.eu8.app.wiz.io/graphql
2025/01/06 09:59:58 [DEBUG] POST https://api.eu8.app.wiz.io/graphql
2025/01/06 09:59:59 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 10:00:02 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 10:00:04 [DEBUG] POST https://api.eu8.app.wiz.io/graphql
2025/01/06 10:00:06 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 10:00:06 [DEBUG] POST https://auth.app.wiz.io/oauth/token
2025/01/06 10:00:07 [DEBUG] POST https://api.eu8.app.wiz.io/graphql
--- PASS: TestAccResourceWizConnectorGcp_basic (15.11s)
PASS
ok      wiz.io/hashicorp/terraform-provider-wiz/internal/acceptance     15.638s

@jschoombee jschoombee merged commit e12be67 into AxtonGrams:main Jan 6, 2025
6 of 7 checks passed
blichev added a commit to blichev/terraform-provider-wiz that referenced this pull request Jan 8, 2025
This PR removes Disk Analyser Config from the AWS Connector. This is due to changes in wiz api where this attribute is not present anymore.

closes AxtonGrams#238
related to AxtonGrams#236
jschoombee pushed a commit that referenced this pull request Jan 9, 2025
This PR removes Disk Analyser Config from the AWS Connector. This is due to changes in wiz api where this attribute is not present anymore.

closes #238
related to #236

Co-authored-by: Boyko Lichev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disk_analyzer_inflight_disabled deprecated and affecting GCP Connector
2 participants