Improve reproducibility of the nix workflows #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nix-installer-action from DeterminateSystems was causing weird reproducibility issues, where the derivation hash produced in the CI differs from the one produced by my local environment. I'm not sure why it's happening, but simply switching to the install-nix-action provided by Cachix fixes this issue.
|
I'll be honest, I still have no idea how this workflow works |
|
In general, I find cachix's much more unreliable - had many occurrences of random fetching and permission issues in the CI while using it. However, if it's good enough for Hyprland's nix CI then it's good enough for me. LGTM, this can be merged @Aylur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nix-installer-actionfromDeterminateSystemswas causing weird reproducibility issues, where the derivation hash produced in the CI differs from the one produced by my local environment.I'm not sure why it's happening, but simply switching to the
install-nix-actionprovided by Cachix fixes this issue. You can test this by building locally, then comparing the produced nix store path with the one in the CI logs.Also added a lib.cleanSource pass to the source tree, to further improve reproducibility.