Use helm for pko #1073
Merged
Use helm for pko #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase pull request. |
janboll
requested review from
bennerv,
geoberle,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
SudoBrendan,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
geoberle
reviewed
Jan 17, 2025
geoberle
reviewed
Jan 17, 2025
tony-schndr
reviewed
Jan 17, 2025
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: cluster-admin |
There was a problem hiding this comment.
Is there a more fine grained role we could use?
There was a problem hiding this comment.
I used the same role used by the PKO team: https://github.com/package-operator/package-operator/blob/f564bbba288a9e3748c871c0eaec329de2ec4cd2/config/self-bootstrap-job.yaml.tpl#L16
So I'll have to ask, if we can reduce the access.
There was a problem hiding this comment.
i think it also comes down to what packages this PKO instance will manage. as we develop a feeling about what kind of resources RVMO will bring in, we could narrow the role towards that.
There was a problem hiding this comment.
Agreed, cause the service account assigned to is used by the operator during runtime.
geoberle
reviewed
Jan 20, 2025
geoberle
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer