Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO-12097 | feat: Use snake case for azure runtime config #1110

Closed
wants to merge 1 commit into from

Conversation

philipwu08
Copy link
Collaborator

What this PR does

Update the keys in the azure runtime config from camel case to snake case.

Jira:
Link to demo recording:

Special notes for your reviewer

@JameelB
Copy link
Collaborator

JameelB commented Jan 20, 2025

I saw that there's another template for this config in the deploy/helm directory: https://github.com/Azure/ARO-HCP/blob/main/cluster-service/deploy/helm/templates/azure-runtime-config.configmap.yaml which I believe is used for the CS rollout pipeline? @tony-schndr @geoberle can you confirm? I think we need to change this in that config as well.

It might be best to add both the camelCase and snake_case fields in these configs to ensure we've a successful rollout? We may need to merge this first before the CS changes, ensure that both versions of the fields are there. Rollout CS that changes from consuming from the camelCase -> snake_case fields. Once that's rolled out, at that point we can remove the old camelCase fields. wdyt?

@philipwu08 philipwu08 force-pushed the runtime-config-snake branch from da5c489 to bb69a01 Compare January 20, 2025 18:15
@philipwu08
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@philipwu08 philipwu08 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants