Skip to content

Commit

Permalink
Set StorageAccount Kind to StorageV2; Min TLS to 1.2 in ARM template
Browse files Browse the repository at this point in the history
  • Loading branch information
tsatam committed Jan 31, 2025
1 parent 0d7eabd commit e1adf8f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 3 additions & 1 deletion pkg/deploy/assets/rp-production-global.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,10 @@
"sku": {
"name": "Standard_LRS"
},
"kind": "StorageV2",
"properties": {
"allowBlobPublicAccess": false
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2"
},
"tags": {},
"location": "[resourceGroup().location]",
Expand Down
1 change: 1 addition & 0 deletions pkg/deploy/generator/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func (g *generator) storageAccount(name string, accountProperties *mgmtstorage.A
Resource: &mgmtstorage.Account{
Name: &name,
Type: to.StringPtr("Microsoft.Storage/storageAccounts"),
Kind: mgmtstorage.KindStorageV2,
Location: to.StringPtr("[resourceGroup().location]"),
Sku: &mgmtstorage.Sku{
Name: "Standard_LRS",
Expand Down
5 changes: 4 additions & 1 deletion pkg/deploy/generator/resources_rp.go
Original file line number Diff line number Diff line change
Expand Up @@ -1520,7 +1520,10 @@ func (g *generator) rpVersionStorageAccount() []*arm.Resource {
return []*arm.Resource{
g.storageAccount(
"[parameters('rpVersionStorageAccountName')]",
&mgmtstorage.AccountProperties{AllowBlobPublicAccess: to.BoolPtr(false)},
&mgmtstorage.AccountProperties{
AllowBlobPublicAccess: to.BoolPtr(false),
MinimumTLSVersion: mgmtstorage.MinimumTLSVersionTLS12,
},
map[string]*string{},
),
}
Expand Down

0 comments on commit e1adf8f

Please sign in to comment.