ARO-6425 v20240812preview validation #3537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable OpenShiftClusterProperties.ServicePrincipalProfile to be set to nil
yithian
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
@microsoft-github-policy-service agree company="Red Hat" |
yithian
added
chainsaw
There was a problem hiding this comment.
The validation code looks good to me. I'm going to attach a hold label here just so we don't collide with ongoing changes in https://github.com/Azure/ARO-RP/pull/3529/files. thanks!
kimorris27
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Thank you for the PR! I recommended some small changes to the validation logic. I'll review again once #3529 has been merged,
pkg/api/v20240812preview/openshiftcluster_validatestatic_test.go
Outdated
Show resolved
Hide resolved
pkg/api/v20240812preview/openshiftcluster_validatestatic_test.go
Outdated
Show resolved
Hide resolved
|
CI is broken on forks so this PR will need to be moved to a branch off the main RP repo. |
|
closing this in favor of #3563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
For ARO-6425
What this PR does / why we need it:
Adds static validation for new API fields added in v20240812preview
Test plan for issue:
Includes unit tests for the new static validation features.
Is there any documentation that needs to be updated for this PR?
No, this is just static validation to ensure inputs are as expected.
How do you know this will function as expected in production?
Unit test data has been written to match expected inputs but nonetheless this should be tested in a lower environment before being pushed to production