disallow refresh_cluster_credentials with platowrm_workload_identities #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawande2
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
slawande2
added
ready-for-review
chainsaw
kimorris27
previously approved these changes
Sep 27, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
kimorris27
previously approved these changes
Sep 30, 2024
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Hopefully this fixes your lint errors. LGTM otherwise.
Running flake8 on extensions...
ERROR: /__w/1/go/src/github.com/Azure/ARO-RP/python/az/aro/azext_aro/tests/latest/unit/test_validators.py:811:123: W291 trailing whitespace
/__w/1/go/src/github.com/Azure/ARO-RP/python/az/aro/build/lib/azext_aro/tests/latest/unit/test_validators.py:811:123: W291 trailing whitespace
2 W291 trailing whitespace
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
previously approved these changes
Oct 2, 2024
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
slawande2
dismissed stale reviews from kimorris27 and shubhadapaithankar
via
6391306
slawande2
force-pushed
the
slawande/ARO-6451
branch
from
6391306 to
2683beb
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
shubhadapaithankar
previously approved these changes
Oct 3, 2024
…dentities" This reverts commit 329322a0fecb15127b316c726f305d374092b113.
slawande2
force-pushed
the
slawande/ARO-6451
branch
from
2905da7 to
6593f24
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
approved these changes
Oct 8, 2024
cadenmarchese
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
ARO-6451
What this PR does / why we need it:
This is a small PR to disallow refresh_cluster_credentials with platform_workload_identites
Test plan for issue:
Unit tests for validating the --platform-workload-identities with --refresh-cluster-credentials argument have been added.
Is there any documentation that needs to be updated for this PR?
Not yet
How do you know this will function as expected in production?
Preview extension-only change. We will perform comprehensive testing before releasing this extension to users.