Default MonitoringEnabled flag to false
#4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahlmant
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
edisonLcardenas
previously approved these changes
Dec 18, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bennerv
reviewed
Jan 14, 2025
bennerv
reviewed
Jan 14, 2025
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hlipsig
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-13325
What this PR does / why we need it:
Defaults to having the monitoring controller in the ARO operator to off. This will allow ARO cluster administrators to enable persistence for the core monitoring stack.
Test plan for issue:
Installed cluster, ran operator locally with flag set.
Is there any documentation that needs to be updated for this PR?
Externally yes
How do you know this will function as expected in production?
Tested on development cluster