Fix MIWI Cluster update flow to add new openshift operator identity #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepc2792
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
rajdeepc2792
added
bug
tsatam
reviewed
Jan 3, 2025
cadenmarchese
previously approved these changes
Jan 3, 2025
kimorris27
reviewed
Jan 3, 2025
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-13916
branch
from
02543e8 to
2e14751
Compare
…after dynamic validation
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-13916
branch
from
2e14751 to
9d8ecb9
Compare
tsatam
approved these changes
Jan 15, 2025
kimorris27
approved these changes
Jan 15, 2025
ehvs
pushed a commit
that referenced
this pull request
Jan 23, 2025
…4037) * ARO-13916 fix new operator identity addition flow for miwi cluster update * ARO-13916 add the federateIdentityCredentials step back to update * ARO-13916 populate client/object IDs after dynamic validation * ARO-13916 update dynamic validation unit test cases * ARO-13916 persist user assigned identities with client and object id after dynamic validation
ehvs
pushed a commit
that referenced
this pull request
Jan 23, 2025
…4037) * ARO-13916 fix new operator identity addition flow for miwi cluster update * ARO-13916 add the federateIdentityCredentials step back to update * ARO-13916 populate client/object IDs after dynamic validation * ARO-13916 update dynamic validation unit test cases * ARO-13916 persist user assigned identities with client and object id after dynamic validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-13916
https://issues.redhat.com/browse/ARO-13924
What this PR does / why we need it:
When adding a new OpenShift Identity to an existing cluster, the federated identity and secret in the cluster must be created.
During testing 2 issues were found, this PR fixes them:
Test plan for issue:
[x] Unit Tests
[x] Test the cluster update in local
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Feature not available in production.