Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert readdition of network_mode to rp container #4044

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kimorris27
Copy link
Contributor

@kimorris27 kimorris27 commented Jan 13, 2025

Which issue this PR addresses:

No Jira

What this PR does / why we need it:

Fixes az aro CLI -> local containerized RP connectivity on MacOS by removing network_mode: host from docker-compose.yml for the RP container.

Test plan for issue:

Tested locally and confirmed that it works well for me. (Ran containerized RP and confirmed that az aro dev CLI could connect)

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

N/A

@geowa4
Copy link

geowa4 commented Jan 13, 2025

Do we need to change some URLs to host.containers.internal to match this networking configuration?

@kimorris27
Copy link
Contributor Author

kimorris27 commented Jan 13, 2025

Do we need to change some URLs to host.containers.internal to match this networking configuration?

@geowa4, which URLs are you thinking we'd need to change?

@geowa4
Copy link

geowa4 commented Jan 13, 2025

Do we need to change some URLs to host.containers.internal to match this networking configuration?

@geowa4, which URLs are you thinking we'd need to change?

If anything is referencing localhost and not calling something in the same container, I would expect it to fail. If there are no such calls, then this change is safe. I'm not sure if any exist but I recall they did at some point.

@kimorris27
Copy link
Contributor Author

Do we need to change some URLs to host.containers.internal to match this networking configuration?

@geowa4, which URLs are you thinking we'd need to change?

If anything is referencing localhost and not calling something in the same container, I would expect it to fail. If there are no such calls, then this change is safe. I'm not sure if any exist but I recall they did at some point.

Gotcha. I can't think of any such calls.

Copy link
Collaborator

@shubhadapaithankar shubhadapaithankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cadenmarchese cadenmarchese merged commit 5cf9da0 into master Feb 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants