ARO-12200 include expected values for MIWI arguments in az aro create usage #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the usage for `az aro create` to show the expected values for the `--assign-platform-workload-identity`/`--assign-platform-wi` and `--mi-user-assigned`/`--assign-cluster-identity` arguments. This should make it easier for users to provide the expected input
yithian
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
fahlmant
reviewed
Jan 16, 2025
yithian
force-pushed
the
yithian/ARO-12200
branch
from
448114c to
8a38c78
Compare
rhamitarora
approved these changes
Jan 20, 2025
cadenmarchese
approved these changes
Jan 20, 2025
rajdeepc2792
approved these changes
Jan 20, 2025
ehvs
pushed a commit
that referenced
this pull request
Jan 23, 2025
… usage (#4050) * include expected values for MIWI arguments in az aro create usage This updates the usage for `az aro create` to show the expected values for the `--assign-platform-workload-identity`/`--assign-platform-wi` and `--mi-user-assigned`/`--assign-cluster-identity` arguments. This should make it easier for users to provide the expected input * Update python/az/aro/azext_aro/_params.py Co-authored-by: Taylor Fahlman <[email protected]> * clarify workload identity usage for cluster creation * add detail for workload identity parameters in usage for upgrade --------- Co-authored-by: Taylor Fahlman <[email protected]>
ehvs
pushed a commit
that referenced
this pull request
Jan 23, 2025
… usage (#4050) * include expected values for MIWI arguments in az aro create usage This updates the usage for `az aro create` to show the expected values for the `--assign-platform-workload-identity`/`--assign-platform-wi` and `--mi-user-assigned`/`--assign-cluster-identity` arguments. This should make it easier for users to provide the expected input * Update python/az/aro/azext_aro/_params.py Co-authored-by: Taylor Fahlman <[email protected]> * clarify workload identity usage for cluster creation * add detail for workload identity parameters in usage for upgrade --------- Co-authored-by: Taylor Fahlman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-12200
What this PR does / why we need it:
This updates the usage for
az aro createto show the expected values for the--assign-platform-workload-identity/--assign-platform-wiand--mi-user-assigned/--assign-cluster-identityarguments. This should make it easier for users to provide the expected inputTest plan for issue:
Ran
az aro create -hafter configuringazto use my local files as the aro extensionIs there any documentation that needs to be updated for this PR?
No, this is updating documentation to match expectations