Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podman verion to update further dep on github.com/cloudflare/circl to fix GHSA-9763-4f94-gfch #4064

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

fahlmant
Copy link
Collaborator

@fahlmant fahlmant commented Jan 28, 2025

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-14552

What this PR does / why we need it:

Fixes GHSA-9763-4f94-gfch by bumping podman version

Before fix:

$ go mod graph | grep github.com/cloudflare/circl
github.com/sylabs/sif/[email protected] github.com/cloudflare/[email protected]

$ go mod graph | grep github.com/cloudflare/circl | while read -r line; do dependency=$(awk '{print $1}' <<<${line}); go mod why -m "${dependency%@*}"; done
# github.com/sylabs/sif/v2
github.com/Azure/ARO-RP/pkg/containerinstall
github.com/containers/podman/v5/pkg/specgen
github.com/containers/common/libimage
github.com/containers/image/v5/transports/alltransports
github.com/containers/image/v5/sif
github.com/sylabs/sif/v2/pkg/sif

After fix:

$ go mod graph | grep github.com/cloudflare/circl
github.com/sylabs/sif/[email protected] github.com/cloudflare/[email protected]

Steps to fix

  1. Update go.mod to use github.com/containers/podman/[email protected]
  2. Add replace in go.mod for github.com/docker/distribution from 2.8.3 to 2.8.2, as 2.8.3 is broken
  3. Run go mod tidy -compat=1.21, go mod vendor and make generate

@fahlmant fahlmant changed the title [WIP] Update podman verion to update further dep on github.com/cloudflare/circl to fix GHSA-9763-4f94-gfch Update podman verion to update further dep on github.com/cloudflare/circl to fix GHSA-9763-4f94-gfch Jan 28, 2025
@fahlmant
Copy link
Collaborator Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tsatam tsatam merged commit 8c9daad into master Jan 29, 2025
22 checks passed
@tsatam tsatam deleted the ARO-14552 branch January 29, 2025 14:05
LiniSusan pushed a commit that referenced this pull request Jan 30, 2025
…ircl to fix GHSA-9763-4f94-gfch (#4064)

* Update podman verion to update further dep on github.com/cloudflare/circl to fix GHSA-9763-4f94-gfch

* Replace docker/distribution 2.8.3 with 2.8.2 as 2.8.3 has broken references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants