Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO-14652: Allow the ability to specify custom master/worker VM sizes in release E2E pipeline #4071

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tof1973
Copy link
Collaborator

@Tof1973 Tof1973 commented Jan 30, 2025

Which issue this PR addresses:

Fixes ARO-14652

What this PR does / why we need it:

Allow user to specify custom master and/or worker Vm Size instead of default one when creating a cluster through E2E pipeline or hack script.

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

SOP for Testing new instance types (docs/adding-new-instance-types.md) as ben updated to use new variables.

How do you know this will function as expected in production?

I have created cluster following the SOP changes, and we need to run the E2E pipeline with it.

@Tof1973
Copy link
Collaborator Author

Tof1973 commented Jan 31, 2025

E2E pipeline has been run to test with those new parameters here
During the test we have seen:

$ az aro show -n v4-e2e-V113872762-westcentralus-prod -g v4-e2e-V113872762-westcentralus-prod | grep -i vmsize
    "vmSize": "Standard_D8s_v4"
    "vmSize": "Standard_D4s_v4"

ARO-Pipeline changes are implemented in here

@Tof1973 Tof1973 marked this pull request as ready for review January 31, 2025 14:31
pkg/util/version/const.go Outdated Show resolved Hide resolved
tsatam
tsatam previously approved these changes Jan 31, 2025
Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a nitpicky request, but I suggested reworking a comment because I'm having trouble understanding what the code directly below it is doing.

pkg/util/cluster/cluster.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants