-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARO-14652: Allow the ability to specify custom master/worker VM sizes in release E2E pipeline #4071
base: master
Are you sure you want to change the base?
Conversation
e778556
to
43e0e21
Compare
E2E pipeline has been run to test with those new parameters here
ARO-Pipeline changes are implemented in here |
43e0e21
to
51b9866
Compare
51b9866
to
69dd931
Compare
69dd931
to
16b9428
Compare
16b9428
to
434650e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of a nitpicky request, but I suggested reworking a comment because I'm having trouble understanding what the code directly below it is doing.
Co-authored-by: Kipp Morris <[email protected]>
Which issue this PR addresses:
Fixes ARO-14652
What this PR does / why we need it:
Allow user to specify custom master and/or worker Vm Size instead of default one when creating a cluster through E2E pipeline or hack script.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
SOP for
Testing new instance types
(docs/adding-new-instance-types.md) as ben updated to use new variables.How do you know this will function as expected in production?
I have created cluster following the SOP changes, and we need to run the E2E pipeline with it.