MIWI bug fix: parse KV error correctly #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare to deleteClusterMsiCertificate() in pkg/cluster/delete_test.go
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
cadenmarchese
approved these changes
Feb 3, 2025
ArrisLee
pushed a commit
that referenced
this pull request
Feb 9, 2025
Compare to deleteClusterMsiCertificate() in pkg/cluster/delete_test.go
s-fairchild
pushed a commit
that referenced
this pull request
Feb 19, 2025
Compare to deleteClusterMsiCertificate() in pkg/cluster/delete_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
No Jira
What this PR does / why we need it:
This PR ensures that we parse any KV errors correctly, preventing cluster creation/deletion from being cut short by non-existent MSI certificates.
Test plan for issue:
Reproduced Caden's issue during cluster creation in local dev and then validated that my change fixes it
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
MIWI feature testing