pkg/env: log MSI data-plane interactions #4080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
2 times, most recently
from
4991508 to
e69838d
Compare
How is this failing? Is this a flake or are all builds broken? |
cadenmarchese
added
ready-for-review
next-release
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
from
1c43d06 to
8a4e2c8
Compare
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
4 times, most recently
from
f0f1e72 to
d9aa072
Compare
|
Please rebase pull request. |
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Previously, we were substituting the entire http transport just to add some client-side middleware. The Azure SDK for Go ships with default transport parameters that we lost by doing this; furthermore, we were not using the per-call policy options to model our middleware, as the SDK expected. Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
from
d9aa072 to
51c1949
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
from
51c1949 to
778002a
Compare
ARM resource IDs are case-insensitive, so the check here needs to be, as well. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/msi-dataplane-middleware
branch
from
778002a to
8ffb212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.