Update all to.Ptr equivalents to our internal one #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tsatam
approved these changes
Feb 5, 2025
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
e2e failed check is the old one. Going to merge as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Consistent usage of a library rather than using 3 different ones.
What this PR does / why we need it:
The team agreed that they want to use the library we've written prior to the k8s generic bumps and what not. If we start using functionality that's present in k8s.io/utils/ptr or azcore, then we will pivot.
https://redhat-internal.slack.com/archives/C02ULBRS68M/p1738697814649279?thread_ts=1731940533.915429&cid=C02ULBRS68M
Test plan for issue:
e2e & CI