[ARO-9308] Add MDSD Certificate rotation tasks to MIMO #4091
Conversation
hawkowl
added
enhancement
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
|
|
||
| // "Rotate" the MDSD certificates in the cluster. The copy that is rotated from | ||
| // comes from RP-Config, and is only able to be updated when the RP is updated. | ||
| func RenewMDSDCertificate(ctx context.Context, log *logrus.Entry, _env env.Interface, ch clienthelper.Interface) error { |
There was a problem hiding this comment.
Not a request for change, just a question for my understanding: what was the motivation to refactor this to use the clienthelper?
There was a problem hiding this comment.
Consistency with the rest of MIMO + better testability (imo).
|
@kimorris27 I'm not sure that I can write an e2e test for this specific case, since it require the env to change (which is a bit hard, although I could probably come up with a way to do it). I'm mostly relying on the e2e to test the codepath works, since I'm fairly sure we do an admin update and that will run it. |
Oh, gotcha... I was not thinking about the fact that E2E runs an admin update. Makes sense. |
Which issue this PR addresses:
Fixes ARO-9308
What this PR does / why we need it:
Adds MDSD certificate rotation to MIMO. Rewrites the code to use ClientHelper. Common underlying implementation between MIMO and AdminUpdate is used, and tests are added for the MIMO usage.
Test plan for issue:
Unit tests + E2E
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
Unit tests :)