Add devops identity as Storage Account Contributor to rpversion SA #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
bitoku,
fahlmant and
sankur-codes
as code owners
jhoreman
reviewed
Feb 11, 2025
| "principalId": "[parameters('globalDevopsServicePrincipalId')]", | ||
| "principalType": "ServicePrincipal" | ||
| }, | ||
| "apiVersion": "2018-09-01-preview", |
There was a problem hiding this comment.
Is this API version correct/desired?
There was a problem hiding this comment.
probably not, but bumping this would require bumping the singleton apiversion we use for all Microsoft.Authorization resources so it'll be an involved effort.
There was a problem hiding this comment.
Ack. No need to cut deeper than we have to for this specific change.
tsatam
force-pushed
the
tsatam/ARO-4399-add-devops-identity-sa-roleassignment
branch
from
cfcbb2a to
cdc8a6f
Compare
jhoreman
approved these changes
Feb 11, 2025
tsatam
changed the title
tsatam
deleted the
tsatam/ARO-4399-add-devops-identity-sa-roleassignment
branch
ArrisLee
pushed a commit
that referenced
this pull request
Feb 16, 2025
s-fairchild
pushed a commit
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Part of building a pipeline to achieve ARO-4399
What this PR does / why we need it:
Adds the Storage Account Contributor role over the rpversion storage account to our devops managed identity. This allows us to build pipelines that upload data to this storage account.
This privilege will be used in an upcoming pipeline to build and deploy the
az aroAzure CLI preview extension into this storage account in order to serve it for external consumption.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
This change should not impact the production service, as it simply adds a new role assignment to the devops identity used during deployments.