-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Data Mapper): Merge with Designer Vs-code Extension #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elaina-Lee <[email protected]>
* moved data mapper extension variables * removed DataMapperExt static vals moved to main ext * moved panel managers from data mapper ext to regular ext * moved image assets and changed names accordingly * changed executeCommand dataMapper to constant LogicAppsStandard
…andard in package.json (#3500) * moved azureDataMapper. commands in package.json from vs-dm to vs-designer * moved data mapper commands to constants * wiped out azureDataMapper telemetry for data mapper commands in vs-code-designer * fixed typos and wrongly referenced variable * added .dataMap in between the commands
merged readme files into vs-code-designer
…ta-mapper (#3513) * added tsconfig to fix merge undefined issue * initialized dataMapPanelManagers for uninitialized error * fixed all outputPath from dm/webview to designer/dm * switched order of build-react & renamed folder * fixed path in webviewHTML for dataMapperPanel & changed imports to fix tsConfig change errors * moved log, showWarning, showError to main extension * changed _setWeebviewHthml to setter using helper * localized all dataMapper log related statements
Elaina-Lee
changed the title
Data Mapper Extension Moved to Designer Vscode
feat(Data Mapper) Merge with Designer Vs-code Extension
Oct 25, 2023
There are some Unchanged files with check annotations from the Github actions in |
Checked and fixed. The warning seems to be gone now! |
Elaina-Lee
changed the title
feat(Data Mapper) Merge with Designer Vs-code Extension
feat(Data Mapper) Merge data mapper with Designer vs code extension
Oct 25, 2023
Elaina-Lee
changed the title
feat(Data Mapper) Merge data mapper with Designer vs code extension
feat(Data Mapper): Merge with Designer Vs-code Extension
Oct 25, 2023
ccastrotrejo
approved these changes
Oct 25, 2023
apps/vs-code-designer/src/app/commands/dataMapper/extensionConfig.ts
Outdated
Show resolved
Hide resolved
ccastrotrejo
approved these changes
Oct 25, 2023
…/merge-extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Merge Vs-code data mapper extension with existing designer vs-code extension
What is the current behavior? (You can also link to an open issue here)
Data mapper has its own extension
What is the new behavior (if this is a feature change)?
Designer vs-code extension contains data mapper
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Please Include Screenshots or Videos of the intended change:
0
AB#25597025