Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Data Mapper): Merge with Designer Vs-code Extension #3461

Merged
merged 13 commits into from
Oct 26, 2023

Conversation

Elaina-Lee
Copy link
Contributor

@Elaina-Lee Elaina-Lee commented Oct 17, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Merge Vs-code data mapper extension with existing designer vs-code extension

  • What is the current behavior? (You can also link to an open issue here)

  • Data mapper has its own extension

  • What is the new behavior (if this is a feature change)?

  • Designer vs-code extension contains data mapper

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Please Include Screenshots or Videos of the intended change:
    0

AB#25597025

Co-authored-by: Elaina-Lee <[email protected]>
* moved data mapper extension variables

* removed DataMapperExt static vals moved to main ext

* moved panel managers from data mapper ext to regular ext

* moved image assets and changed names accordingly

* changed executeCommand dataMapper to constant LogicAppsStandard
…andard in package.json (#3500)

* moved azureDataMapper. commands in package.json from vs-dm to vs-designer

* moved data mapper commands to constants

* wiped out azureDataMapper telemetry for data mapper commands in vs-code-designer

* fixed typos and wrongly referenced variable

* added .dataMap in between the commands
merged readme files into vs-code-designer
…ta-mapper (#3513)

* added tsconfig to fix merge undefined issue

* initialized dataMapPanelManagers for uninitialized error

* fixed all outputPath from dm/webview to designer/dm

* switched order of build-react & renamed folder

* fixed path in webviewHTML for dataMapperPanel & changed imports to fix tsConfig change errors

* moved log, showWarning, showError to main extension

* changed _setWeebviewHthml to setter using helper

* localized all dataMapper log related statements
@Elaina-Lee Elaina-Lee changed the title Data Mapper Extension Moved to Designer Vscode feat(Data Mapper) Merge with Designer Vs-code Extension Oct 25, 2023
@Elaina-Lee Elaina-Lee marked this pull request as ready for review October 25, 2023 18:22
@ccastrotrejo
Copy link
Contributor

There are some Unchanged files with check annotations from the Github actions inlibs/data-mapper/src/lib/ui/ReactFlowWrapper.tsx Could you check those?

@Elaina-Lee
Copy link
Contributor Author

There are some Unchanged files with check annotations from the Github actions inlibs/data-mapper/src/lib/ui/ReactFlowWrapper.tsx Could you check those?

Checked and fixed. The warning seems to be gone now!

@Elaina-Lee Elaina-Lee changed the title feat(Data Mapper) Merge with Designer Vs-code Extension feat(Data Mapper) Merge data mapper with Designer vs code extension Oct 25, 2023
@Elaina-Lee Elaina-Lee changed the title feat(Data Mapper) Merge data mapper with Designer vs code extension feat(Data Mapper): Merge with Designer Vs-code Extension Oct 25, 2023
@Elaina-Lee Elaina-Lee linked an issue Oct 25, 2023 that may be closed by this pull request
@Elaina-Lee Elaina-Lee enabled auto-merge (squash) October 25, 2023 23:32
@Elaina-Lee Elaina-Lee disabled auto-merge October 25, 2023 23:32
@Elaina-Lee Elaina-Lee merged commit c3a6d43 into main Oct 26, 2023
@Elaina-Lee Elaina-Lee deleted the feat/merge-extensions branch October 26, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Data Mapper Extension with Logic Apps Extension
3 participants