Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Update dropzone automation ids to use node names and align with card … #3729

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

Aleks-gdb
Copy link
Contributor

@Aleks-gdb Aleks-gdb commented Nov 20, 2023

Update dropzone automation ids to use node names and align with card automation ids.

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Aligns data-automation-ids for card and add button for easier maintenance.

  • What is the current behavior? (You can also link to an open issue here)
    image

  • What is the new behavior (if this is a feature change)?
    The button id and data automation id use the display name of the operation vs the id. Same as the card.
    image

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    This would break existing tests relying on the previous style of data-automation-ids and button id

  • Please Include Screenshots or Videos of the intended change:
    No UI change.

@Aleks-gdb Aleks-gdb changed the title Update dropzone automation ids to use node names and align with card … fix(designer): Update dropzone automation ids to use node names and align with card … Nov 20, 2023
Copy link
Contributor

@Eric-B-Wu Eric-B-Wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we move all instances of .replace(/\W/g, '-') in libs\utils\src\lib\helpers\stringFunctions.ts and use the function instead?

@Eric-B-Wu Eric-B-Wu enabled auto-merge (squash) November 28, 2023 20:08
@Eric-B-Wu Eric-B-Wu merged commit d567972 into Azure:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants