Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer-ui): Prevent expressions using &...; syntax disappearing from HTML editor #3760

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

ek68794998
Copy link
Contributor

@ek68794998 ek68794998 commented Nov 27, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

When entering into the HTML editor an expression that contains an HTML entity such as <, it will disappear from the editor upon save or after switching nodes. Fixes #3741.

  • What is the new behavior (if this is a feature change)?

Expression no longer disappears.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Please Include Screenshots or Videos of the intended change:

Showing token not disappearing:

disappearing-expr-fix

When the above example is saved, it properly serializes when being sent to the server:

image

AB#25970447

@ek68794998 ek68794998 changed the title Ek/expr html fix(designer-ui): Prevent expressions using &...; syntax disappearing from HTML editor Nov 27, 2023
@ek68794998 ek68794998 marked this pull request as draft November 27, 2023 23:34
@ek68794998
Copy link
Contributor Author

ek68794998 commented Nov 27, 2023

Dropping back to a draft while I work on fixing test case (see comments). Fixed; see resolved comment.

@ek68794998 ek68794998 marked this pull request as ready for review November 28, 2023 00:40
@ek68794998 ek68794998 requested a review from Eric-B-Wu November 28, 2023 19:43
@ek68794998 ek68794998 merged commit b7b7aaa into Azure:main Nov 28, 2023
@ek68794998 ek68794998 deleted the ek/expr-html branch November 28, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expressions containing HTML '&...;' components disappear from HTML editor
2 participants