Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Scope Nodes Permanently Loading #6458

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

Eric-B-Wu
Copy link
Contributor

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

Any scope node added will always show as loading due to a regression

New Behavior

Setting initial Data as null, so Reacy Query accurately reflects the data loading state in isLoading

Impact of Change

  • This is a breaking change.

Test Plan

I've added a simple base case test that will show the condition scope action card which should alert if this comes up again

Screenshots or Videos (if applicable)

@Eric-B-Wu Eric-B-Wu requested a review from hartra344 as a code owner January 23, 2025 18:18
@Eric-B-Wu Eric-B-Wu enabled auto-merge (squash) January 23, 2025 18:22
@Eric-B-Wu Eric-B-Wu merged commit 0ec40fd into main Jan 23, 2025
12 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/fixScopeLoading branch January 23, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants