Implement subnet-ids parameter #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirit100
force-pushed
the
implement-subnet-ids
branch
3 times, most recently
from
34bd1a2 to
c6e4dc9
Compare
Also needed to update dependencies for this to work. This is a squash of 7 commits: first try second try third try updated meta info added libraries removed necessity for dns label fr this time Old summary: implemented subnet-ids, private IPs, updated lots of stuff
nirit100
force-pushed
the
implement-subnet-ids
branch
from
c6e4dc9 to
727cd48
Compare
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and necessarily updated a lot of the code on the way.
The workflow now accepts a list of
subnet-idsto deploy the image to.To be able to do that, I had to
So I had to touch a lot of stuff I do not know much about. I tested it with a work related project, so I cannot share anything about that, but it worked there and the API seems to report errors in the input very nicely.
This is aiming to resolve #74
Please just let me know if there is something wrong with the PR, I am new to Azure and related Workflows.