feat(generator): use InputOperation.OperationId
#5210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2025 16:24
Previously we use resource name to guess operation id, which doesn't work well in some cases. Instead of gussing operation id in generator, we try best to get the id in emitter and pass it to generator. resolve Azure#5117
archerzz
commented
Jan 6, 2025
| @@ -431,7 +431,7 @@ public virtual ArmOperation<ManagedHsmResource> Update(WaitUntil waitUntil, Mana | |||
| /// </item> | |||
| /// <item> | |||
| /// <term>Operation Id</term> | |||
| /// <description>MHSMPrivateLinkResources_ListByMhsmResource</description> | |||
There was a problem hiding this comment.
The new operation id is what defined in swagger:
archerzz
commented
Jan 6, 2025
| @@ -24,7 +24,7 @@ public partial class Sample_FooCollection | |||
| public async Task CreateOrUpdate_CreateAFoo() | |||
| { | |||
| // Generated from example definition: 2024-05-01/Foos_CreateOrUpdate.json | |||
| // this example is just showing the usage of "Foo_CreateOrUpdate" operation, for the dependent resources, they will have to be created separately. | |||
There was a problem hiding this comment.
It should be Foos, not Foo which is a regression when upgrading to tsp 0.61.2: https://github.com/Azure/autorest.csharp/pull/5110/files#diff-22fec97a025df3dec39b67b814688ef812fb9f7dfd2f85b3cc48d2501823415b
archerzz
commented
Jan 6, 2025
| @@ -151,7 +151,7 @@ public static Response<FooResource> GetFoo(this ResourceGroupResource resourceGr | |||
| /// </item> | |||
| /// <item> | |||
| /// <term>Operation Id</term> | |||
| /// <description>PrivateLinkResource_GetAllPrivateLinkResources</description> | |||
| /// <description>PrivateLinks_listByMongoCluster</description> | |||
There was a problem hiding this comment.
here is the difference between original name and @clientName:
archerzz
commented
Jan 6, 2025
| @@ -215,7 +215,7 @@ public static Pageable<MgmtTypeSpecPrivateLinkResourceData> GetAllPrivateLinkRes | |||
| /// </item> | |||
| /// <item> | |||
| /// <term>Operation Id</term> | |||
| /// <description>PrivateLinks_Start</description> | |||
| /// <description>PrivateLinks_start</description> | |||
There was a problem hiding this comment.
the original name is start:
There was a problem hiding this comment.
Note that before 0.61.2, it's still Start.
archerzz
commented
Jan 6, 2025
| @@ -264,7 +264,7 @@ public virtual ArmOperation Delete(WaitUntil waitUntil, CancellationToken cancel | |||
| /// </item> | |||
| /// <item> | |||
| /// <term>Operation Id</term> | |||
| /// <description>Foo_CreateOrUpdate</description> | |||
| /// <description>Foos_createOrUpdate</description> | |||
There was a problem hiding this comment.
original name is createOrUpdate:
archerzz
pushed a commit
to archerzz/azure-sdk-for-net
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we used resource name to guess operation id, which doesn't work well in some cases.
Instead of gussing operation id in generator, we try best to get the id in emitter and pass it to generator.
resolve #5117
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?