Update column validation logic for insert operations when considering request-body-strict #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Aniruddh25,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
abhishekkumams
approved these changes
Jan 19, 2025
|
/azp run |
sezal98
approved these changes
Jan 22, 2025
|
/azp run |
Aniruddh25
reviewed
Jan 23, 2025
...ce.Tests/SqlTests/RestApiTests/RestBodyNonStrictModeTests/MsSqlRestBodyNonStrictModeTests.cs
Show resolved
Hide resolved
What do you mean by files here? |
Aniruddh25
approved these changes
Jan 23, 2025
typo, meant to be fields, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2526
What is this change?
Update the logic within
RequestValidator.ValidateColumnto correctly handle therequest-body-strictsetting for calculated and auto-generated fields.How was this tested?
Added an additional test to cover auto-generated fields in the request body when
request-body-strictis set tofalse. This code path is for all read only fields which also covers computed columns, and other columns that will return as read only during startup.Sample Request(s)
Can make a post request for any table that has auto-generated or computed columns. For example;
https://localhost:5001/restApi/Book/
with a request body:
{
"id": 9999,
"publisher_id": 1234,
"title": "Foo"
}